From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755964AbcBPUDE (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 15:03:04 -0500
Received: from mail.kernel.org ([198.145.29.136]:34809 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755854AbcBPUDA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 15:03:00 -0500
Date: Tue, 16 Feb 2016 17:02:56 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, eranian@google.com, mingo@kernel.org,
        linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/8] perf, tools, stat: Move noise/running printing into
 printout
Message-ID: <20160216200256.GI17690@kernel.org>
References: <1454173616-17710-1-git-send-email-andi@firstfloor.org>
 <1454173616-17710-4-git-send-email-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454173616-17710-4-git-send-email-andi@firstfloor.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Sat, Jan 30, 2016 at 09:06:51AM -0800, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Move the running/noise printing into printout to avoid
> duplicated code in the callers.
> 
> v2: Merged with other patches. Remove unnecessary hunk.
> Readd hunk that ended in earlier patch.
> v3: Fix noise/running output in CSV mode
> v4: Merge with later patch that also moves not supported printing.
> Acked-by: Jiri Olsa <jolsa@kernel.org>

So, the description makes it look like this is just elliminating code
duplication, but then, before we had:

  [acme@jouet linux]$ perf.old stat -I 500 -e instructions,cycles sleep 1
  #           time             counts unit events
       0.500164711            548,376      instructions              #    0.72  insn per cycle                                            
       0.500164711            756,872      cycles                                                      
       1.000405470      <not counted>      instructions             
       1.000405470      <not counted>      cycles                   
       1.000690913            156,623      instructions              #    0.48  insn per cycle                                            
       1.000690913            226,630      cycles                                                      
  [acme@jouet linux]$

And now we have instead:

  [acme@jouet linux]$ perf stat -I 500 -e instructions,cycles sleep 1
  #           time             counts unit events
       0.500173751            555,962      instructions              #    0.77  insn per cycle                                            
       0.500173751            722,964      cycles                                                      
       1.000382613                  0      instructions              #    0.00  insn per cycle                                            
       1.000382613                  0      cycles                                                      
       1.001157068            154,765      instructions              #    0.49  insn per cycle                                            
       1.001157068            223,609      cycles                                                      
  [acme@jouet linux]$ 

So there is a change in behaviour.

- Arnaldo