From: Benoit Parrot <bparrot@ti.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: <linux-kernel@vger.kernel.org>,
Sakari Ailus <sakari.ailus@iki.fi>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Bryan Wu <cooloney@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
<linux-media@vger.kernel.org>
Subject: Re: [PATCH v2] [media] v4l2-async: Don't fail if registered_async isn't implemented
Date: Tue, 16 Feb 2016 14:11:51 -0600 [thread overview]
Message-ID: <20160216201151.GH1380@ti.com> (raw)
In-Reply-To: <1455653001-10043-1-git-send-email-javier@osg.samsung.com>
Tested-by: Benoit Parrot <bparrot@ti.com>
Javier Martinez Canillas <javier@osg.samsung.com> wrote on Tue [2016-Feb-16 17:03:21 -0300]:
> After sub-dev registration in v4l2_async_test_notify(), the v4l2-async
> core calls the registered_async callback but if a sub-dev driver does
> not implement it, v4l2_subdev_call() will return a -ENOIOCTLCMD which
> should not be considered an error.
>
> Reported-by: Benoit Parrot <bparrot@ti.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v2:
> - Check the return of v4l2_subdev_call (Benoit).
>
> drivers/media/v4l2-core/v4l2-async.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
> index 716bfd47daab..a4b224d92572 100644
> --- a/drivers/media/v4l2-core/v4l2-async.c
> +++ b/drivers/media/v4l2-core/v4l2-async.c
> @@ -120,7 +120,7 @@ static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
> }
>
> ret = v4l2_subdev_call(sd, core, registered_async);
> - if (ret < 0) {
> + if (ret < 0 && ret != -ENOIOCTLCMD) {
> if (notifier->unbind)
> notifier->unbind(notifier, sd, asd);
> return ret;
> --
> 2.5.0
>
next prev parent reply other threads:[~2016-02-16 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 20:03 [PATCH v2] [media] v4l2-async: Don't fail if registered_async isn't implemented Javier Martinez Canillas
2016-02-16 20:11 ` Benoit Parrot [this message]
2016-02-17 9:38 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216201151.GH1380@ti.com \
--to=bparrot@ti.com \
--cc=cooloney@gmail.com \
--cc=javier@osg.samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).