From: Johannes Thumshirn <jthumshirn@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, nfont@linux.vnet.ibm.com,
brking@linux.vnet.ibm.com, manoj@linux.vnet.ibm.com,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines
Date: Wed, 17 Feb 2016 09:05:36 +0100 [thread overview]
Message-ID: <20160217080536.GJ18134@c203.arch.suse.de> (raw)
In-Reply-To: <yq1k2m4xclf.fsf@sermon.lab.mkp.net>
On Tue, Feb 16, 2016 at 10:03:24PM -0500, Martin K. Petersen wrote:
> >>>>> "Tyrel" == Tyrel Datwyler <tyreld@linux.vnet.ibm.com> writes:
>
> >> Is there some reason you didn't carry the review tag over from this:
> >>
> >> http://mid.gmane.org/20160204084459.GW27969@c203.arch.suse.de
> >>
> >> ?
> >>
> >> James
>
> Tyrel> The patch is slightly changed from v1. A define for AIX os type
> Tyrel> was added as mentioned in the cover letter v2 changes, and I
> Tyrel> moved the defines to the mad_adapter_info_data structure around
> Tyrel> the fields they apply.
>
> Johannes: Mind checking this out?
I'm sorry I though I already did.
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
> https://patchwork.kernel.org/patch/8276101/
>
> --
> Martin K. Petersen Oracle Linux Engineering
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-02-17 8:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 1:32 [PATCH v2 0/7] ibmvscsi code cleanup Tyrel Datwyler
2016-02-11 1:32 ` [PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums Tyrel Datwyler
2016-02-12 14:29 ` Manoj Kumar
2016-02-11 1:32 ` [PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values Tyrel Datwyler
2016-02-11 8:51 ` Johannes Thumshirn
2016-02-12 14:23 ` Manoj Kumar
2016-02-11 1:32 ` [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines Tyrel Datwyler
2016-02-12 16:43 ` James Bottomley
2016-02-12 16:51 ` Tyrel Datwyler
2016-02-12 16:53 ` James Bottomley
2016-02-12 16:57 ` Martin K. Petersen
2016-02-17 3:03 ` Martin K. Petersen
2016-02-17 8:05 ` Johannes Thumshirn [this message]
2016-02-12 22:06 ` Manoj Kumar
2016-02-11 1:32 ` [PATCH v2 4/7] ibmvscsi: Use of_root to access OF device tree root node Tyrel Datwyler
2016-02-11 1:32 ` [PATCH v2 5/7] ibmvscsi: Remove unsupported host config MAD Tyrel Datwyler
2016-02-11 8:53 ` Johannes Thumshirn
2016-02-11 1:32 ` [PATCH v2 6/7] ibmvscsi: Add endian conversions to sysfs attribute show functions Tyrel Datwyler
2016-02-11 1:32 ` [PATCH v2 7/7] ibmvscsi: use H_CLOSED instead of magic number Tyrel Datwyler
2016-02-11 8:54 ` Johannes Thumshirn
2016-02-12 16:55 ` [PATCH v2 0/7] ibmvscsi code cleanup Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217080536.GJ18134@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=manoj@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).