From: Ingo Molnar <mingo@kernel.org>
To: Stas Sergeev <stsp@list.ru>
Cc: Andy Lutomirski <luto@kernel.org>,
x86@kernel.org, Denys Vlasenko <dvlasenk@redhat.com>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Pavel Emelyanov <xemul@parallels.com>,
Brian Gerst <brgerst@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v5 1/4] x86/signal/64: Add a comment about sigcontext->fs and gs
Date: Wed, 17 Feb 2016 12:05:22 +0100 [thread overview]
Message-ID: <20160217110522.GA30222@gmail.com> (raw)
In-Reply-To: <56C44560.6010708@list.ru>
* Stas Sergeev <stsp@list.ru> wrote:
> 17.02.2016 10:21, Ingo Molnar пишет:
> >
> > * Andy Lutomirski <luto@kernel.org> wrote:
> >
> >> + * If the kernel ever adds explicit fs, gs, fsbase, and gsbase
> >> + * save/restore, it will most likely need to be opt-in and use
> >> + * different context slots.
> >
> > Btw., that's not necessarily true: it could also be made opt-out, and a
> > modify_ldt() or any other cleanly identifiable legacy usage/signature that is
> > associated with DOSEMU might trigger the opt-out automatically as well.
> But there are the new versions of dosemu that still use
> "modify_ldt() or any other cleanly identifiable legacy usage/signature"
> and yet wants a new functionality.
> Please don't go for such an unreliable heuristic.
Only if implemented dumbly.
Implemented intelligently there would be 3 runtime states: enabled, disabled,
automatic. New DOSEMU would explicitly enable it, which would override any
automatic defaults.
But note that I was only pointing out that the comment is needlessly restrictive.
Anyway, I have applied Andy's patches.
Thanks,
Ingo
next prev parent reply other threads:[~2016-02-17 11:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 23:09 [PATCH v5 0/4] x86: sigcontext fixes, again Andy Lutomirski
2016-02-16 23:09 ` [PATCH v5 1/4] x86/signal/64: Add a comment about sigcontext->fs and gs Andy Lutomirski
2016-02-17 7:21 ` Ingo Molnar
2016-02-17 10:03 ` Stas Sergeev
2016-02-17 11:05 ` Ingo Molnar [this message]
2016-02-17 12:10 ` [tip:x86/asm] x86/signal/64: Add a comment about sigcontext-> fs " tip-bot for Andy Lutomirski
2016-02-16 23:09 ` [PATCH v5 2/4] x86/signal/64: Fix SS if needed when delivering a 64-bit signal Andy Lutomirski
2016-02-17 12:10 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
2016-02-16 23:09 ` [PATCH v5 3/4] x86/signal/64: Re-add support for SS in the 64-bit signal context Andy Lutomirski
2016-02-17 12:11 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
2016-02-16 23:09 ` [PATCH v5 4/4] selftests/x86: Add tests for UC_SIGCONTEXT_SS and UC_STRICT_RESTORE_SS Andy Lutomirski
2016-02-17 12:11 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217110522.GA30222@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=stsp@list.ru \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).