From: Darren Hart <dvhart@infradead.org>
To: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
Cc: Oleksandr Natalenko <oleksandr@natalenko.name>,
corentin.chary@gmail.com, acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD
Date: Wed, 17 Feb 2016 21:34:34 -0800 [thread overview]
Message-ID: <20160218053434.GF18421@dvhart-mobl5.amr.corp.intel.com> (raw)
In-Reply-To: <20160217103738.GA1609@tyrael>
On Wed, Feb 17, 2016 at 12:37:38PM +0200, Giedrius Statkevičius wrote:
> On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote:
> > Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
> > is loaded with wapf=4 option. Add quirk for this.
> > ---
>
> You forgot Signed-off-by here. Always run your patch through
> scripts/checkpatch.pl. Also, I think the format is usually
> [PATCH RESEND vX AA/BB] and not [PATCH][RESEND].
RESEND means it's identical. v2 means there was a change. The change should be
noted below the --- line. See Documentation/SubmittingPatches Section 14.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-02-18 5:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 7:45 [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Oleksandr Natalenko
2016-02-17 10:37 ` Giedrius Statkevičius
2016-02-18 5:34 ` Darren Hart [this message]
2016-02-18 5:25 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218053434.GF18421@dvhart-mobl5.amr.corp.intel.com \
--to=dvhart@infradead.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=giedrius.statkevicius@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).