linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "jianqun.xu" <jay.xu@rock-chips.com>,
	heiko@sntech.de, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	jwerner@chromium.org, catalin.marinas@arm.com,
	will.deacon@arm.com, sboyd@codeaurora.org,
	linus.walleij@linaro.org, sjoerd.simons@collabora.co.uk,
	huangtao@rock-chips.com, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/6] ASoC: rockchip: add bindings for rk3399 i2s
Date: Thu, 18 Feb 2016 14:59:54 +0000	[thread overview]
Message-ID: <20160218145954.GI7129@sirena.org.uk> (raw)
In-Reply-To: <20160218143702.GN9654@rob-hp-laptop>

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

On Thu, Feb 18, 2016 at 08:37:02AM -0600, Rob Herring wrote:
> On Wed, Feb 17, 2016 at 11:03:06AM +0000, Mark Brown wrote:

> > As with the other patch I'd expect to see a matching driver update if
> > only for documentation purposes.

> Why? They match on the prior chip's compatible until there is some 
> difference the driver needs to handle.

That then requires anyone using a compatible string to also know the
full set of other compatible strings that can be used for this device
and that they have to list the others too in the correct order which
isn't something the binding document tells them.  It also feels better
to record in the code how we think we should support the device when we
know it, seems more helpful.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-02-18 15:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17  1:53 [PATCH 0/6] Add core dtsi for rk3399 from Rockchip jianqun.xu
2016-02-17  1:53 ` [PATCH 1/6] clk: rockchip: add dt-binding header for rk3399 jianqun.xu
2016-02-17  1:53 ` [PATCH 2/6] spi: rockchip: add bindings for rk3399 spi jianqun.xu
2016-02-18 14:37   ` Rob Herring
2016-02-17  1:53 ` [PATCH 3/6] ASoC: rockchip: add bindings for rk3399 i2s jianqun.xu
2016-02-17 11:03   ` Mark Brown
2016-02-18 14:37     ` Rob Herring
2016-02-18 14:59       ` Mark Brown [this message]
2016-02-18 14:36   ` Rob Herring
2016-02-17  1:53 ` [PATCH 4/6] pinctrl: rockchip: add bindings for rk3399 pinctrl jianqun.xu
2016-02-17  6:47   ` Heiko Stuebner
2016-02-17  7:23     ` Jianqun Xu
2016-02-17  1:54 ` [PATCH 5/6] dt-bindings: add documentation of rk3399 clock controller jianqun.xu
2016-02-18 14:36   ` Rob Herring
2016-02-19  0:48     ` Jianqun Xu
2016-02-19  0:53       ` Heiko Stuebner
2016-02-19  1:05         ` Jianqun Xu
2016-02-17  2:01 ` [PATCH 6/6] ARM64: dts: rockchip: add core dtsi file for rk3399 jianqun.xu
2016-02-17  7:00   ` Heiko Stuebner
2016-02-18  1:43     ` Jianqun Xu
2016-02-17 11:27   ` Marc Zyngier
2016-02-17 11:46   ` Mark Rutland
2016-02-18  1:07     ` Jianqun Xu
2016-02-17  2:04 ` [PATCH 1/6] clk: rockchip: add dt-binding header " jianqun.xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218145954.GI7129@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jay.xu@rock-chips.com \
    --cc=jwerner@chromium.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=sjoerd.simons@collabora.co.uk \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).