From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427783AbcBSSgw (ORCPT ); Fri, 19 Feb 2016 13:36:52 -0500 Received: from muru.com ([72.249.23.125]:46710 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423636AbcBSSgu (ORCPT ); Fri, 19 Feb 2016 13:36:50 -0500 Date: Fri, 19 Feb 2016 10:36:47 -0800 From: Tony Lindgren To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Daniel Lezcano , Nishanth Menon , Pavel Machel , Aaro Koskinen , Sebastian Reichel , Ivaylo Dimitrov , Lorenzo Pieralisi , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] omap3: Add cpuidle parameters table for omap3430 Message-ID: <20160219183647.GL21202@atomide.com> References: <20160215152542.GS19432@atomide.com> <1455559328-19783-1-git-send-email-pali.rohar@gmail.com> <56C2F387.3040803@linaro.org> <20160216100752.GF1476@pali> <20160216160859.GE19432@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160216160859.GE19432@atomide.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [160216 08:11]: > * Pali Rohár [160216 02:09]: > > On Tuesday 16 February 2016 11:01:43 Daniel Lezcano wrote: > > > On 02/15/2016 07:02 PM, Pali Rohár wrote: > > > >Based on CPU type choose generic omap3 or omap3430 specific cpuidle > > > >parameters. Parameters for omap3430 were measured on Nokia N900 device and > > > >added by commit 5a1b1d3a9efa ("OMAP3: RX-51: Pass cpu idle parameters") > > > >which were later removed by commit 231900afba52 ("ARM: OMAP3: cpuidle - > > > >remove rx51 cpuidle parameters table") due to huge code complexity. > > > > > > > >This patch brings cpuidle parameters for omap3430 devices again, but uses > > > >simple condition based on CPU type. > > > > > > > >Signed-off-by: Pali Rohár > > > >Fixes: 231900afba52d6faddfb480cde4132d4edc089bc > > > >--- > > > > > > Acked-by: Daniel Lezcano > > > > Tony, Nishanth (or somebody else...) can you test this patch on more > > omap3 devices to check if it does not break existing cpuidle code? > > Seems to work for me on a ldp, which is GP 3430 ES3.0. OK applying this into omap-for-v4.6/fixes-not-urgent considering we've already lived with it for years. Regards, Tony