From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753237AbcBURdM (ORCPT ); Sun, 21 Feb 2016 12:33:12 -0500 Received: from mout2.freenet.de ([195.4.92.92]:57600 "EHLO mout2.freenet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752736AbcBURdJ (ORCPT ); Sun, 21 Feb 2016 12:33:09 -0500 Date: Sun, 21 Feb 2016 10:15:53 +0100 From: Sascha Sommer To: SF Markus Elfring Cc: linux-mmc@vger.kernel.org, Ulf Hansson , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 2/2] mmc-sdricoh_cs: Less checks in sdricoh_init_mmc() after, error detection Message-ID: <20160221101553.7fd64e70@madeira.sommer.dynalias.net> In-Reply-To: <5682F4ED.4070803@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <5682F3AC.7050107@users.sourceforge.net> <5682F4ED.4070803@users.sourceforge.net> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.28; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Originated-At: 85.180.7.255!38851 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Am Tue, 29 Dec 2015 22:02:37 +0100 schrieb SF Markus Elfring : > From: Markus Elfring > Date: Tue, 29 Dec 2015 21:45:34 +0100 > > This issue was detected by using the Coccinelle software. > > Two pointer checks could be repeated by the sdricoh_init_mmc() > function during error handling even if the relevant properties can be > determined for the involved variables before by source code analysis. > > * This implementation detail could be improved by adjustments > for jump targets according to the Linux coding style convention. > > * Drop an unnecessary initialisation for the variable "mmc" then. > > Signed-off-by: Markus Elfring > --- Acked-by: Sascha Sommer Best regards Sascha