From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757353AbcBWEmt (ORCPT ); Mon, 22 Feb 2016 23:42:49 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:58963 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757303AbcBWEmj (ORCPT ); Mon, 22 Feb 2016 23:42:39 -0500 Date: Mon, 22 Feb 2016 23:42:34 -0500 (EST) Message-Id: <20160222.234234.1952119173455287427.davem@davemloft.net> To: diego.viola@gmail.com Cc: festevam@gmail.com, cooldavid@cooldavid.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, richard.weinberger@gmail.com, pavel@ucw.cz, rjw@rjwysocki.net Subject: Re: [PATCH] net: jme: fix suspend/resume on JMC260 From: David Miller In-Reply-To: References: <1456187572-2964-1-git-send-email-diego.viola@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 Feb 2016 20:42:39 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Diego Viola Date: Mon, 22 Feb 2016 22:58:48 -0300 > On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: >> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: >>> Signed-off-by: Diego Viola >> >> You should write a commit log. > > I thought about including the link to my bug report: > https://bugzilla.kernel.org/show_bug.cgi?id=112351 > > What else would you suggest I add to the commit message? The commit message is where you describe the change you are making. This includes exactly what you are fixing, how you are doing it, and why you are doing it that way. Empty commit log messages are %99.99999 of the time completely inappropriate.