From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755275AbcBWFIU (ORCPT ); Tue, 23 Feb 2016 00:08:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53382 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926AbcBWFIS (ORCPT ); Tue, 23 Feb 2016 00:08:18 -0500 Date: Tue, 23 Feb 2016 07:08:07 +0200 From: "Michael S. Tsirkin" To: Gabriel Somlo Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, arnd@arndb.de, lersek@redhat.com, ralf@linux-mips.org, rmk+kernel@arm.linux.org.uk, eric@anholt.net, hanjun.guo@linaro.org, zajec5@gmail.com, sudeep.holla@arm.com, agross@codeaurora.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, qemu-devel@nongnu.org, imammedo@redhat.com, peter.maydell@linaro.org, leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, pbonzini@redhat.com, kraxel@redhat.com, ehabkost@redhat.com, luto@amacapital.net, stefanha@gmail.com, revol@free.fr, matt@codeblueprint.co.uk, rth@twiddle.net Subject: Re: [PATCH] firmware: fw_cfg register offsets on supported architectures only Message-ID: <20160223070757-mutt-send-email-mst@redhat.com> References: <20160222211818.GJ16357@HEDWIG.INI.CMU.EDU> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160222211818.GJ16357@HEDWIG.INI.CMU.EDU> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 04:18:18PM -0500, Gabriel Somlo wrote: > Refrain from defining default fw_cfg register offsets on > unsupported architectures -- throw an error instead. If > QEMU were to add fw_cfg support on additional architectures, > we should add them to the FW_CFG_SYSFS depends statement in > drivers/firmware/Kconfig, and provide default values for > register offsets in drivers/firmware/qemu_fw_cfg.c at that > time. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Gabriel Somlo Acked-by: Michael S. Tsirkin > --- > drivers/firmware/qemu_fw_cfg.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c > index fedbff5..79f6b7b 100644 > --- a/drivers/firmware/qemu_fw_cfg.c > +++ b/drivers/firmware/qemu_fw_cfg.c > @@ -109,9 +109,7 @@ static void fw_cfg_io_cleanup(void) > # define FW_CFG_CTRL_OFF 0x00 > # define FW_CFG_DATA_OFF 0x01 > # else > -# warning "QEMU FW_CFG may not be available on this architecture!" > -# define FW_CFG_CTRL_OFF 0x00 > -# define FW_CFG_DATA_OFF 0x01 > +# error "QEMU FW_CFG not available on this architecture!" > # endif > #endif > > -- > 2.4.3