From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751359AbcBWMLy (ORCPT ); Tue, 23 Feb 2016 07:11:54 -0500 Received: from mail.skyhub.de ([78.46.96.112]:34794 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbcBWMLx (ORCPT ); Tue, 23 Feb 2016 07:11:53 -0500 Date: Tue, 23 Feb 2016 13:11:42 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: tony.luck@intel.com, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, dougthompson@xmission.com, mchehab@osg.samsung.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, gong.chen@linux.intel.com, len.brown@intel.com, peterz@infradead.org, ak@linux.intel.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error Message-ID: <20160223121142.GA3673@pd.tnic> References: <1455659111-32074-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1455659111-32074-4-git-send-email-Aravind.Gopalakrishnan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1455659111-32074-4-git-send-email-Aravind.Gopalakrishnan@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2016 at 03:45:10PM -0600, Aravind Gopalakrishnan wrote: > The Deferred field indicates if we have a Deferred error. > Deferred errors indicate errors that hardware could not > fix. But it still does not cause any interruption to program > flow. So it does not generate any #MC and UC bit in MCx_STATUS > is not set. > > Fixing comment here. No functional change > > Signed-off-by: Aravind Gopalakrishnan > --- > arch/x86/include/asm/mce.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h > index 2ec67ac..476da8b 100644 > --- a/arch/x86/include/asm/mce.h > +++ b/arch/x86/include/asm/mce.h > @@ -40,7 +40,7 @@ > #define MCI_STATUS_AR (1ULL<<55) /* Action required */ > > /* AMD-specific bits */ > -#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare an uncorrected error */ > +#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare a deferred error */ /* uncorrected error, deferred exception */ sounds better to me. > #define MCI_STATUS_POISON (1ULL<<43) /* access poisonous data */ > #define MCI_STATUS_TCC (1ULL<<55) /* Task context corrupt */ > /* > -- For the future, such cleanups/fixes should always go first in the patch set. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.