From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755030AbcBWTDz (ORCPT ); Tue, 23 Feb 2016 14:03:55 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:59918 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753250AbcBWTDw (ORCPT ); Tue, 23 Feb 2016 14:03:52 -0500 Date: Tue, 23 Feb 2016 11:03:46 -0800 From: Johannes Weiner To: Mel Gorman Cc: Linux-MM , Rik van Riel , Vlastimil Babka , LKML Subject: Re: [PATCH 06/27] mm, vmscan: Begin reclaiming pages on a per-node basis Message-ID: <20160223190346.GG13816@cmpxchg.org> References: <1456239890-20737-1-git-send-email-mgorman@techsingularity.net> <1456239890-20737-7-git-send-email-mgorman@techsingularity.net> <20160223185722.GF13816@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160223185722.GF13816@cmpxchg.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2016 at 10:57:22AM -0800, Johannes Weiner wrote: > > @@ -2558,16 +2579,12 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc) > > sc->gfp_mask |= __GFP_HIGHMEM; > > > > for_each_zone_zonelist_nodemask(zone, z, zonelist, > > - requested_highidx, sc->nodemask) { > > It's unfortunate that we start with the lowest zone here. For Normal > allocations, the most common allocations, this will always have two > full shrink_node() rounds that skip over everything >DMA in the first, > then over everything >DMA32 in the second, even though all pages on > the node are valid reclaim candidates for that allocation. Nevermind, I'm confused about zonelist ordering. It starts with the highest indexed zones.