From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752670AbcBXKV4 (ORCPT ); Wed, 24 Feb 2016 05:21:56 -0500 Received: from outbound-smtp02.blacknight.com ([81.17.249.8]:53795 "EHLO outbound-smtp02.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbcBXKVw (ORCPT ); Wed, 24 Feb 2016 05:21:52 -0500 Date: Wed, 24 Feb 2016 10:21:49 +0000 From: Mel Gorman To: Johannes Weiner Cc: Linux-MM , Rik van Riel , Vlastimil Babka , LKML Subject: Re: [PATCH 06/27] mm, vmscan: Begin reclaiming pages on a per-node basis Message-ID: <20160224102149.GS2854@techsingularity.net> References: <1456239890-20737-1-git-send-email-mgorman@techsingularity.net> <1456239890-20737-7-git-send-email-mgorman@techsingularity.net> <20160223185722.GF13816@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20160223185722.GF13816@cmpxchg.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2016 at 10:57:22AM -0800, Johannes Weiner wrote: > On Tue, Feb 23, 2016 at 03:04:29PM +0000, Mel Gorman wrote: > > @@ -2428,10 +2448,11 @@ static bool shrink_zone(struct zone *zone, struct scan_control *sc, > > reclaimed = sc->nr_reclaimed; > > scanned = sc->nr_scanned; > > > > + sc->reclaim_idx = reclaim_idx; > > shrink_zone_memcg(zone, memcg, sc, &lru_pages); > > zone_lru_pages += lru_pages; > > The setting of sc->reclaim_idx is unexpected here. Why not set it in > the caller and eliminate the reclaim_idx parameter? > Initially because it was easier to develop the patch for but it's good either way. I updated this patch and handled the conflicts. It's now set in the callers. Thanks. -- Mel Gorman SUSE Labs