From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933832AbcBZTDq (ORCPT ); Fri, 26 Feb 2016 14:03:46 -0500 Received: from mail.kernel.org ([198.145.29.136]:38605 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932751AbcBZTDp (ORCPT ); Fri, 26 Feb 2016 14:03:45 -0500 Date: Fri, 26 Feb 2016 16:03:35 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: Peter Zijlstra , Ingo Molnar , Taeung Song , linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Thomas Gleixner , Lai Jiangshan Subject: Re: [RFC] Re: [PATCH v3 1/2] tracing/syscalls: Rename variable 'nr' to '__syscall_nr' Message-ID: <20160226190335.GW8720@kernel.org> References: <1456492446-5896-1-git-send-email-treeze.taeung@gmail.com> <20160226135713.GU8720@kernel.org> <20160226132301.3ae065a4@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160226132301.3ae065a4@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Feb 26, 2016 at 01:23:01PM -0500, Steven Rostedt escreveu: > On Fri, 26 Feb 2016 10:57:13 -0300 Arnaldo Carvalho de Melo wrote: > > If we stand by published ABIs, we should keep it written in stone and > > state that the first 'nr' means '__syscall_nr' while keeping it as-is, > > the change for 'perf trace' in that case is to do nothing, it work > > as-is, we have just to fix the python binding to do that rename. > > Perhaps we can live with that, to avoid having three different cases: > > !nr, nr and __syscall_nr. > > We could, do this as well. Want me to add something to event-parse? You mean do nothing in the kernel? Suits me fine, the fix would be just on the tools/perf/ code, where it generates the python skeletons, I can do that, as I guess Taeung is sleep at this point :-) - Arnaldo