From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755002AbcBZVX0 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Feb 2016 16:23:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33891 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750699AbcBZVXZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Feb 2016 16:23:25 -0500
Date: Fri, 26 Feb 2016 22:23:15 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 1/5] perf report: Fix comparing of dynamic entries
Message-ID: <20160226212315.GC19398@krava.redhat.com>
References: <1456512767-1164-1-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1456512767-1164-1-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 27, 2016 at 03:52:43AM +0900, Namhyung Kim wrote:
> When hist_entry__cmp() and hist_entry__collapse() are called, it should
> check the dynamic entry is comparing matching hists only.  Otherwise it
> might access different hists resulting in incorrect output.

the whole patchset looks good to me:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka