From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758842AbcB1QRH (ORCPT ); Sun, 28 Feb 2016 11:17:07 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:60954 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758666AbcB1QRE (ORCPT ); Sun, 28 Feb 2016 11:17:04 -0500 Date: Sun, 28 Feb 2016 11:16:56 -0500 From: Johannes Weiner To: Mel Gorman Cc: Linux-MM , Rik van Riel , Vlastimil Babka , LKML Subject: Re: [PATCH 09/27] mm, vmscan: Simplify the logic deciding whether kswapd sleeps Message-ID: <20160228161656.GD25622@cmpxchg.org> References: <1456239890-20737-1-git-send-email-mgorman@techsingularity.net> <1456239890-20737-10-git-send-email-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456239890-20737-10-git-send-email-mgorman@techsingularity.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2016 at 03:04:32PM +0000, Mel Gorman wrote: > kswapd goes through some complex steps trying to figure out if it > should stay awake based on the classzone_idx and the requested order. > It is unnecessarily complex and passes in an invalid classzone_idx to > balance_pgdat(). What matters most of all is whether a larger order has > been requsted and whether kswapd successfully reclaimed at the previous > order. This patch irons out the logic to check just that and the end result > is less headache inducing. > > Signed-off-by: Mel Gorman Acked-by: Johannes Weiner