From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Ingo Molnar <mingo@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Dave Hansen <dave@sr71.net>,
linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com,
akpm@linux-foundation.org, tglx@linutronix.de, mingo@elte.hu,
peterz@infradead.org, linux-next@vger.kernel.org, deller@gmx.de
Subject: Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field
Date: Tue, 1 Mar 2016 09:54:32 +1100 [thread overview]
Message-ID: <20160301095432.29f247e0@canb.auug.org.au> (raw)
In-Reply-To: <20160229080143.GB31950@gmail.com>
Hi Ingo,
On Mon, 29 Feb 2016 09:01:43 +0100 Ingo Molnar <mingo@kernel.org> wrote:
>
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > > u32?
> >
> > It would have to be __u32, but we already use int and unsigned int
> > extensively in the siginfo structure (which are both always assumed to
> > be 32 bits). So "unsigned int" probably makes most sense.
>
> No. This whole mishap is an object lesson in why it's a bad idea to ever use ABI
> types outside of the __[us][8|16|32|64] space: some of them are 'fine', some of
> them (like longs) are not.
Absolutely. I was just trying to be consistent with the rest of the structure.
Dave has submitted a follow up version which I have Acked.
--
Cheers,
Stephen Rothwell
prev parent reply other threads:[~2016-02-29 22:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 17:34 [PATCH] x86, pkeys: fix siginfo ABI breakage from new field Dave Hansen
2016-02-26 17:44 ` H. Peter Anvin
2016-02-26 22:10 ` Stephen Rothwell
2016-02-27 11:41 ` Ingo Molnar
2016-02-27 19:16 ` Dave Hansen
2016-02-27 19:35 ` H. Peter Anvin
2016-02-27 23:26 ` Stephen Rothwell
2016-02-27 23:40 ` [PATCH v2] signals, pkeys: make si_pkey 32 bits Stephen Rothwell
2016-02-29 7:57 ` Ingo Molnar
2016-02-29 8:01 ` [PATCH] x86, pkeys: fix siginfo ABI breakage from new field Ingo Molnar
2016-02-29 22:54 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301095432.29f247e0@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=deller@gmx.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).