linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alexandre TORGUE <alexandre.torgue@gmail.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] Documentation: Bindings: Add STM32 DWMAC glue
Date: Wed, 2 Mar 2016 12:33:09 -0600	[thread overview]
Message-ID: <20160302183309.GA2449@rob-hp-laptop> (raw)
In-Reply-To: <1456483912-32090-3-git-send-email-alexandre.torgue@gmail.com>

On Fri, Feb 26, 2016 at 11:51:50AM +0100, Alexandre TORGUE wrote:
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com>
> 
> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt
> new file mode 100644
> index 0000000..67fceda
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt
> @@ -0,0 +1,40 @@
> +STMicroelectronics STM32 / MCU DWMAC glue layer controller
> +
> +This file documents platform glue layer for stmmac.
> +Please see stmmac.txt for the other unchanged properties.
> +
> +The device node has following properties.
> +
> +Required properties:
> +- compatible:  Should be "st,stm32-dwmac" to select glue, and
> +	       "snps,dwmac-3.50a" to select IP vesrion.
> +- clocks: Should contain the GMAC main clock, and tx clock
> +- compatible:  Should be "st,stm32-dwmac" to select glue and
> +	       "snps,dwmac-3.50a" to select IP version.
> +- clocks: Should contain the MAC main clock
> +- clock-names: Should contain the clock names "stmmaceth".
> +- st,syscon : Should be phandle/offset pair. The phandle to the syscon node which
> +	      encompases the glue register, and the offset of the control register.
> +
> +Optional properties:
> +- clocks: Could contain:
> +	- the tx clock,
> +	- the rx clock
> +- clock-names: Could contain the clock names "tx-clk", "rx-clk"

Either the IP block has 3 clocks or it has 1. If you have a case where 1 
clock feeds all 3 inputs, then list the clock 3 times.

Rob

  parent reply	other threads:[~2016-03-02 18:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 10:51 [PATCH v3 0/4] Add Ethernet support on STM32F429 Alexandre TORGUE
2016-02-26 10:51 ` [PATCH v3 1/4] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip Alexandre TORGUE
2016-02-26 18:08   ` Joachim Eastwood
2016-02-26 10:51 ` [PATCH v3 2/4] Documentation: Bindings: Add STM32 DWMAC glue Alexandre TORGUE
2016-02-26 17:57   ` Joachim Eastwood
2016-03-02 18:33   ` Rob Herring [this message]
2016-03-04  9:04     ` Alexandre Torgue
2016-02-26 10:51 ` [PATCH v3 3/4] net: ethernet: stmmac: add support of Synopsys 3.50a MAC IP Alexandre TORGUE
2016-02-26 10:51 ` [PATCH v3 4/4] ARM: STM32: Enable Ethernet in stm32_defconfig Alexandre TORGUE
2016-03-01 17:36   ` Maxime Coquelin
2016-02-29  9:36 ` [PATCH v3 0/4] Add Ethernet support on STM32F429 Giuseppe CAVALLARO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302183309.GA2449@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=alexandre.torgue@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).