From: David Miller <davem@davemloft.net>
To: alexandre.torgue@st.com
Cc: fengguang.wu@intel.com, peppe.cavallaro@st.com,
kbuild-all@01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stmmac: fix noderef.cocci warnings
Date: Fri, 04 Mar 2016 16:32:38 -0500 (EST) [thread overview]
Message-ID: <20160304.163238.95510004512138022.davem@davemloft.net> (raw)
In-Reply-To: <56D98374.6020003@st.com>
From: Alexandre Torgue <alexandre.torgue@st.com>
Date: Fri, 4 Mar 2016 13:45:40 +0100
> Hi,
>
> On 03/03/2016 02:55 AM, kbuild test robot wrote:
>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:115:15-21:
>> ERROR: application of sizeof to pointer
>>
>> sizeof when applied to a pointer typed expression gives the size of
>> the pointer
>>
>> Generated by: scripts/coccinelle/misc/noderef.cocci
>>
>> CC: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>>
>> stmmac_platform.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -112,7 +112,7 @@ static struct stmmac_axi *stmmac_axi_set
>> if (!np)
>> return NULL;
>>
>> - axi = kzalloc(sizeof(axi), GFP_KERNEL);
>> + axi = kzalloc(sizeof(*axi), GFP_KERNEL);
>> if (!axi)
>> return ERR_PTR(-ENOMEM);
>>
>>
>
>
> Thanks.
> You can add my Acked-by: Alexandre Torgue <alexandre.torgue@st.com>
Don't do this.
Automated tools look for Acked-by: tags in replies to patch postings
in a certain way, so you must provide you Acked-by: on the first
column of a line in order for it to be picked up properly by those
tools.
next prev parent reply other threads:[~2016-03-04 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201603030907.6ptkaLfJ%fengguang.wu@intel.com>
2016-03-03 1:55 ` [PATCH] stmmac: fix noderef.cocci warnings kbuild test robot
2016-03-04 12:45 ` Alexandre Torgue
2016-03-04 21:32 ` David Miller [this message]
2016-03-07 3:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304.163238.95510004512138022.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).