From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760548AbcCDXcp (ORCPT ); Fri, 4 Mar 2016 18:32:45 -0500 Received: from mga14.intel.com ([192.55.52.115]:1765 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760369AbcCDXco (ORCPT ); Fri, 4 Mar 2016 18:32:44 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,538,1449561600"; d="scan'208";a="664064932" Date: Sat, 5 Mar 2016 01:32:41 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Peter Huewe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm_crb: fix: associate to the correct device Message-ID: <20160304233241.GA25079@intel.com> References: <1455708211-9653-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160218180331.GA7191@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160218180331.GA7191@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 11:03:31AM -0700, Jason Gunthorpe wrote: > > + INIT_LIST_HEAD(&resources); > > + rc = acpi_dev_get_resources(device, &resources, crb_check_resource, > > + priv); > > + if (rc < 0) > > + return rc; > > + acpi_dev_free_resource_list(&resources); > > I wonder if the acpi_dev_free_resource_list is what kill's the > resource name? Maybe that needs to be delayed until after the > ioremap, which is best done with this back in crb_map_io ?? > > Thanks for looking at this stuff, I had almost forgotten this comment. I'll try this out as soon as possible. Might well be the reason. > Jason /Jarkko