From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754249AbcCEMnd (ORCPT ); Sat, 5 Mar 2016 07:43:33 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35690 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760797AbcCEMmS (ORCPT ); Sat, 5 Mar 2016 07:42:18 -0500 Date: Sat, 5 Mar 2016 14:01:09 +0900 From: Mark Brown To: Sagar Dharia Cc: gregkh@linuxfoundation.org, bp@suse.de, poeschel@lemonage.de, treding@nvidia.com, gong.chen@linux.intel.com, andreas.noever@gmail.com, alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch, oded.gabbay@amd.com, jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com, davem@davemloft.net, james.hogan@imgtec.com, michael.opdenacker@free-electrons.com, daniel.thompson@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kheitke@audience.com, mlocke@codeaurora.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org Message-ID: <20160305050109.GC18327@sirena.org.uk> References: <1454784265-5194-1-git-send-email-sdharia@codeaurora.org> <1454784265-5194-2-git-send-email-sdharia@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Wb3vNW4H1K9tQ0lO" Content-Disposition: inline In-Reply-To: <1454784265-5194-2-git-send-email-sdharia@codeaurora.org> X-Cookie: Adapt. Enjoy. Survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 110.170.137.3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V4 1/6] SLIMbus: Device management on SLIMbus X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Wb3vNW4H1K9tQ0lO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 06, 2016 at 11:44:20AM -0700, Sagar Dharia wrote: > +static void schedule_slim_report(struct slim_controller *ctrl, > + struct slim_device *sb, bool report) > +{ > + struct sb_report_wd *sbw; > + > + dev_dbg(&ctrl->dev, "report:%d for slave:%s\n", report, sb->name); > + > + sbw = kmalloc(sizeof(*sbw), GFP_KERNEL); > + if (!sbw) > + return; > + > + INIT_WORK(&sbw->wd, slim_report); > + sbw->sb = sb; > + sbw->report = report; > + if (!queue_work(ctrl->wq, &sbw->wd)) { > + dev_err(&ctrl->dev, "failed to queue report:%d slave:%s\n", > + report, sb->name); > + kfree(sbw); > + } > +} I'm not 100% clear why we're scheduling this into a workqueue, it'd probably help to at least explain what's going on in the code for future reference. > +} > +/** There's an awful lot of places in this which look like they're missing blank lines. > +ret_assigned_laddr: > + mutex_unlock(&ctrl->m_ctrl); > + if (exists || ret) > + return ret; > + > + pr_info("setting slimbus l-addr:%x, ea:%x,%x,%x,%x\n", > + *laddr, e_addr->manf_id, e_addr->prod_code, > + e_addr->dev_index, e_addr->instance); Not a dev_ print? > + slim = slim_query_device(ctrl, e_addr); > + if (!slim) { > + ret = -ENOMEM; -ENOMEM? > +static void __exit slimbus_exit(void) > +{ > + bus_unregister(&slimbus_type); > +} > + > +static int __init slimbus_init(void) > +{ > + return bus_register(&slimbus_type); > +} > +postcore_initcall(slimbus_init); > +module_exit(slimbus_exit); Put the annotatations next to their functions. > +MODULE_DESCRIPTION("Slimbus module"); > +MODULE_ALIAS("platform:slimbus"); This isn't a platform driver, it shouldn't have this alias. > diff --git a/include/linux/slimbus.h b/include/linux/slimbus.h > new file mode 100644 > index 0000000..2a78f79 > --- /dev/null > +++ b/include/linux/slimbus.h Probably good to add a module_slimbus_device() macro like other buses have. --Wb3vNW4H1K9tQ0lO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW2mgTAAoJECTWi3JdVIfQqwcH/Rc1kyCZNk008bgDJm7EThzA mX6ViQUcLGilaRknRlZMieXCE5OLiHaKM9vCVNb9NIGLUxn4397CGS5neglY7Cd5 eZclO0xqkW1tot4lR/pAjzyKKsC8/u3RHvRI/GaGgVfOTsaBwR7O7by4og3SRuKN tcnwnh8zH0R3+W4OZIhPdwqcCQVCn8X+4v2MPwrZ9slklPi4yKLwhpSiJ4QaYTSe rUCqMRNWZPYs1fYY4n/O0kry4ebZb6ozhBuAhh3a/qwDU7Z9nGQWOoXQAC1OUZS/ 5zdALr4ujK/YgSW9bzBwXIIHXuPOAbhWrFE7PoxJL7BTxf7DvxDh/+TieF22gSU= =PLEj -----END PGP SIGNATURE----- --Wb3vNW4H1K9tQ0lO--