linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: perf, tools: Refactor and support interval and CSV metrics
Date: Mon, 7 Mar 2016 19:48:39 +0100	[thread overview]
Message-ID: <20160307184839.GA15870@krava.redhat.com> (raw)
In-Reply-To: <20160307182227.GC5083@two.firstfloor.org>

On Mon, Mar 07, 2016 at 07:22:27PM +0100, Andi Kleen wrote:
> On Mon, Mar 07, 2016 at 11:08:42AM +0100, Jiri Olsa wrote:
> > On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote:
> > 
> > SNIP
> > 
> > > 
> > > % perf stat -x, --metric-only  -a -I 1000
> > >      1.001381652,frontend cycles idle,insn per cycle,stalled cycles per insn,branch-misses of all branches,
> > >      1.001381652,173.32,0.83,2.09,1.73,
> > >      2.002073343,199.47,1.07,1.60,2.14,
> > >      3.002875524,109.52,0.22,7.83,1.63,
> > >      4.003970059,132.10,0.17,10.85,1.51,
> > >      5.004818754,181.60,0.22,8.87,2.22,
> > > 
> > > 
> > > Available in
> > > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 perf/stat-metrics-21
> > 
> > this branch contains old version of:
> >   perf, tools, stat: Add --metric-only support for -A
> 
> Old in what way? Looks correct to me.
> 
> 
> commit e26ba80593023c24c8276ad9853acd7e56ca92ed
> Author: Andi Kleen <ak@linux.intel.com>
> Date:   Sat Dec 19 11:22:55 2015 -0800
> 
>     perf, tools, stat: Add --metric-only support for -A
>     
>     Add metric only support for -A too. This requires a new print
>     function that prints the metrics in the right order.
>     
>     v2: Fix manpage
>     v3: Simplify nrcpus computation
>     Signed-off-by: Andi Kleen <ak@linux.intel.com>

I did not see the change for print_no_aggr_metric function
in commit:
   perf, tools, stat: Add --metric-only support for -A

which I saw in the email..

however now im confused, I did not noticed I had a wrong tree,
however git can't resolve the git tree you mentioned:

> Available in
> git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 perf/stat-metrics-21

	[jolsa@krava perf]$ git remote add ak1 git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 
	[jolsa@krava perf]$ git remote update ak1
	Fetching ak1
	fatal: remote error: access denied or repository not exported: /pub/scm/linux/kernel/git/ak/linux-misc-2.6
	error: Could not fetch ak1

so I guess the one I have is the correct one:
	git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc

however:
	[jolsa@krava perf]$ git remote update ak
	Fetching ak
	[jolsa@krava perf]$ git branch -r | grep stat-metrics-21
	[jolsa@krava perf]$

jirka

  reply	other threads:[~2016-03-07 18:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 23:57 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-03-03 23:57 ` [PATCH 1/7] perf, tools, stat: Check existence of frontend/backed stalled cycles Andi Kleen
2016-03-03 23:57 ` [PATCH 2/7] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-03-03 23:57 ` [PATCH 3/7] perf, tools, stat: Support metrics in --per-core/socket mode Andi Kleen
2016-03-03 23:57 ` [PATCH 4/7] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-03-10 11:29   ` Jiri Olsa
2016-03-11  8:52   ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-03-03 23:57 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-03-10 11:28   ` Jiri Olsa
2016-03-11  8:52   ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-03-03 23:57 ` [PATCH 6/7] perf, tools, stat: Add --metric-only support for -A Andi Kleen
2016-03-10 11:32   ` Jiri Olsa
2016-03-11  8:52   ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-03-03 23:57 ` [PATCH 7/7] perf, tools, stat: Check for frontend stalled for metrics Andi Kleen
2016-03-07 10:08 ` perf, tools: Refactor and support interval and CSV metrics Jiri Olsa
2016-03-07 18:22   ` Andi Kleen
2016-03-07 18:48     ` Jiri Olsa [this message]
2016-03-07 21:11       ` Andi Kleen
2016-03-10 11:34         ` Jiri Olsa
  -- strict thread matches above, loose matches on Subject: below --
2016-03-03  0:24 Andi Kleen
2016-03-01 18:57 Andi Kleen
2016-03-01 19:05 ` Arnaldo Carvalho de Melo
2016-02-29 22:36 Andi Kleen
2016-03-01 13:07 ` Arnaldo Carvalho de Melo
2016-02-27  0:27 Andi Kleen
2016-02-17 22:43 Andi Kleen
2016-01-30 17:06 Andi Kleen
2016-01-27  0:42 Andi Kleen
2016-01-20  2:26 Andi Kleen
2016-01-22 10:10 ` Jiri Olsa
2016-01-16  1:11 Andi Kleen
2016-01-16 20:21 ` Jiri Olsa
2016-01-18 22:25   ` Andi Kleen
2015-07-30  0:21 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160307184839.GA15870@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).