From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751212AbcCHVyi (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Mar 2016 16:54:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56617 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750866AbcCHVya (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Mar 2016 16:54:30 -0500
Date: Tue, 8 Mar 2016 22:54:25 +0100
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>, joro@8bytes.org,
        bp@alien8.de, gleb@kernel.org, alex.williamson@redhat.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com,
        sherry.hurwitz@amd.com
Subject: Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC
Message-ID: <20160308215424.GA31328@potion.brq.redhat.com>
References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com>
 <1457124368-2025-7-git-send-email-Suravee.Suthikulpanit@amd.com>
 <56DD9FF5.7010201@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56DD9FF5.7010201@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-03-07 16:36+0100, Paolo Bonzini:
> On 04/03/2016 21:46, Suravee Suthikulpanit wrote:
>> +static void svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec)
>> +{
>> +	struct vcpu_svm *svm = to_svm(vcpu);
>> +
>> +	kvm_lapic_set_vector(vec, avic_get_bk_page_entry(svm, APIC_IRR));

(I think that smp_mb here would make sense, even though we're fine now
 thanks to re-checking vcpu->mode in kvm_vcpu_kick.
 A comment explaining this optimization would be nice.  I'm thinking
 about a race where we don't send the doorbell even though the VCPU is
 in guest mode, because vcpu->mode was read before writing APIC_IRR.)

>> +
>> +	if (vcpu->mode == IN_GUEST_MODE) {
>> +		wrmsrl(SVM_AVIC_DOORBELL,
>> +		       __default_cpu_present_to_apicid(vcpu->cpu));
>> +	} else {
>> +		kvm_vcpu_kick(vcpu);
>> +	}
> 
> You also need to add
> 
> 	kvm_make_request(KVM_REQ_EVENT, vcpu);
> 
> before the "if", similar to vmx_deliver_posted_interrupt.

KVM won't do anything in KVM_REQ_EVENT and I think that the request can
be avoided because KVM already has to handle IRR writes from AVIC.

And what about
  [...]
  else if (!vcpu->...->is_running)
  	kvm_vcpu_kick(vcpu);

?
The kick isn't needed unless the VCPU is scheduled out.

Or maybe just
  if (vcpu->...->is_running)
    wrmsrl()
  else
    kvm_vcpu_kick();
?
Which doesn't use the information we have on top AVIC, making our logic
a bit simpler.