From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751322AbcCHWF4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Mar 2016 17:05:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54589 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750787AbcCHWFr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Mar 2016 17:05:47 -0500
Date: Tue, 8 Mar 2016 23:05:41 +0100
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>, joro@8bytes.org,
        bp@alien8.de, gleb@kernel.org, alex.williamson@redhat.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com,
        sherry.hurwitz@amd.com
Subject: Re: [PART1 RFC v2 07/10] svm: Add VMEXIT handlers for AVIC
Message-ID: <20160308220541.GA29455@potion.brq.redhat.com>
References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com>
 <1457124368-2025-8-git-send-email-Suravee.Suthikulpanit@amd.com>
 <56DDA50B.7090609@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56DDA50B.7090609@redhat.com>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 08 Mar 2016 22:05:46 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-03-07 16:58+0100, Paolo Bonzini:
>> +	case AVIC_INCMP_IPI_ERR_INV_TARGET:
>> +		pr_err("%s: Invalid IPI target (icr=%#08x:%08x, idx=%u)\n",
>> +		       __func__, icrh, icrl, index);
>> +		BUG();
>> +		break;
>> +	case AVIC_INCMP_IPI_ERR_INV_BK_PAGE:
>> +		pr_err("%s: Invalid bk page (icr=%#08x:%08x, idx=%u)\n",
>> +		       __func__, icrh, icrl, index);
>> +		BUG();
>> +		break;
> 
> Please use WARN(1, "%s: Invalid bk page (icr=%#08x:%08x, idx=%u)\n",
> __func__, icrh, icrl, index) (and likewise for invalid target) instead
> of BUG().

I think that if we hit one of these, then WARNs would just flood the
log.  I'd prefer WARN_ONCE on AVIC_INCMP_IPI_ERR_INV_BK_PAGE.
(Btw. aren't icr and idx are pointless on this error?  and the function
 name should be printed by WARN.)

Invalid target is triggerable by the guest (by sending IPI to a
non-existent LAPIC), so warning log level seems too severe.
pr_info_ratelimited() or nothing would be better.