Re: [PATCH 02/13] hwmon: convert ntc_thermistor to use devm_thermal_zone_of_sensor_register

From: kbuild test robot <lkp@intel.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: kbuild-all@01.org, Rui Zhang <rui.zhang@intel.com>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org, Eduardo Valentin <edubezval@gmail.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 02/13] hwmon: convert ntc_thermistor to use devm_thermal_zone_of_sensor_register
Date: Thu, 10 Mar 2016 08:14:08 +0800	[thread overview]
Message-ID: <201603100848.txDpqq9E%fengguang.wu@intel.com> (raw)
In-Reply-To: <1457559336-17652-3-git-send-email-edubezval@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2488 bytes --]

Hi Eduardo,

[auto build test WARNING on soc-thermal/next]
[also build test WARNING on v4.5-rc7 next-20160309]
[cannot apply to thermal/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Eduardo-Valentin/thermal-convert-users-of-thermal_zone_of_sensor_register-to-devm_/20160310-054318
base:   https://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal next
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   drivers/hwmon/ntc_thermistor.c: In function 'ntc_thermistor_probe':
   drivers/hwmon/ntc_thermistor.c:636:2: error: implicit declaration of function 'devm_thermal_zone_of_sensor_register' [-Werror=implicit-function-declaration]
     tz = devm_thermal_zone_of_sensor_register(data->dev, 0, data->dev,
     ^
>> drivers/hwmon/ntc_thermistor.c:636:5: warning: assignment makes pointer from integer without a cast
     tz = devm_thermal_zone_of_sensor_register(data->dev, 0, data->dev,
        ^
   cc1: some warnings being treated as errors

vim +636 drivers/hwmon/ntc_thermistor.c

   620		ret = sysfs_create_group(&data->dev->kobj, &ntc_attr_group);
   621		if (ret) {
   622			dev_err(data->dev, "unable to create sysfs files\n");
   623			return ret;
   624		}
   625	
   626		data->hwmon_dev = hwmon_device_register(data->dev);
   627		if (IS_ERR(data->hwmon_dev)) {
   628			dev_err(data->dev, "unable to register as hwmon device.\n");
   629			ret = PTR_ERR(data->hwmon_dev);
   630			goto err_after_sysfs;
   631		}
   632	
   633		dev_info(&pdev->dev, "Thermistor type: %s successfully probed.\n",
   634									pdev_id->name);
   635	
 > 636		tz = devm_thermal_zone_of_sensor_register(data->dev, 0, data->dev,
   637							  &ntc_of_thermal_ops);
   638		if (IS_ERR(tz))
   639			dev_dbg(&pdev->dev, "Failed to register to thermal fw.\n");
   640	
   641		return 0;
   642	err_after_sysfs:
   643		sysfs_remove_group(&data->dev->kobj, &ntc_attr_group);
   644		ntc_iio_channel_release(pdata);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 44067 bytes --]