From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909AbcCJMEE (ORCPT ); Thu, 10 Mar 2016 07:04:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:36015 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752086AbcCJMDy (ORCPT ); Thu, 10 Mar 2016 07:03:54 -0500 Date: Thu, 10 Mar 2016 13:03:52 +0100 From: Johannes Thumshirn To: Sudip Mukherjee Cc: Jens Axboe , Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] block: fix possible NULL dereference Message-ID: <20160310120352.GG16624@c203.arch.suse.de> References: <1457609953-24101-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1457609953-24101-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 10, 2016 at 05:09:13PM +0530, Sudip Mukherjee wrote: > We were checking for iter to be NULL after dereferencing it. Lets first > check it and then use it. > > Signed-off-by: Sudip Mukherjee Good catch Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850