From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753196AbcCJQEw (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Mar 2016 11:04:52 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42180 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752574AbcCJQEp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Mar 2016 11:04:45 -0500
Date: Thu, 10 Mar 2016 17:04:36 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <andi@firstfloor.org>, Borislav Petkov <bp@suse.de>,
        Colin Ian King <colin.king@canonical.com>,
        David Ahern <dsahern@gmail.com>, Davidlohr Bueso <dbueso@suse.com>,
        He Kuang <hekuang@huawei.com>, Mel Gorman <mgorman@suse.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>,
        Steven Rostedt <rostedt@goodmis.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH] perf tool: Build jitdump only on supported archs
Message-ID: <20160310160436.GA9604@krava.redhat.com>
References: <1457379891-28516-1-git-send-email-acme@kernel.org>
 <20160310093229.GB11206@krava.redhat.com>
 <20160310155700.GB3102@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160310155700.GB3102@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 10, 2016 at 12:57:00PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Mar 10, 2016 at 10:32:29AM +0100, Jiri Olsa escreveu:
> > On Mon, Mar 07, 2016 at 04:44:36PM -0300, Arnaldo Carvalho de Melo wrote:
> > 
> > SNIP
> > 
> > > ----------------------------------------------------------------
> > > Adrian Hunter (5):
> > >       perf inject: Hit all DSOs for AUX data in JIT and other cases
> > >       perf session: Simplify tool stubs
> > >       perf jit: Let jit_process() return errors
> > >       perf jit: Move clockid validation
> > >       perf tools: Use 64-bit shifts with (TSC) time conversion
> > 
> > hi,
> > perf build failed for me on s390x because of jitdump feature.
> > 
> > Attached patch tries to enable the build only on supported archs.
> > 
> > I haven't followed this feature too much, so I might have missed
> > something.. anyway it builds on s390x now ;-) I took the list of
> > archs from util/genelf.h
> 
> Hi Jiri,
> 
> 	This may be related to this cset, still not in tip/perf/core:
> 
>   commit 46dad054a19297af65c417c97cb920aa5bdf7e8c
>   Author: Arnaldo Carvalho de Melo <acme@redhat.com>
>   Date:   Mon Mar 7 18:48:45 2016 -0300
> 
>     perf jitdump: DWARF is also needed
> 
> Can you check if without this one perf builds on s390? 
> 
> This patch is to make it build on ubuntu without libdw, i.e. it requires
> both libdw and libelf, the way I fixed it may not be the best and
> probably we need to fold these two patches before sending to Ingo, since
> your patch essentially rewrites my previous patch :-)
> 
> Can you please check that?

well there's following line in util/genelf.h:

#else
#error "unsupported architecture"
#endif

which makes the build fail on unssuported arch,
even without your patch:

  CC       util/jitdump.o
In file included from util/jitdump.c:23:
util/genelf.h:41:2: error: #error "unsupported architecture"
util/genelf.h:44:5: error: "GEN_ELF_CLASS" is not defined
mv: cannot stat `util/.jitdump.o.tmp': No such file or directory
make[3]: *** [util/jitdump.o] Error 1


jirka