From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932929AbcCKQov (ORCPT ); Fri, 11 Mar 2016 11:44:51 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:35324 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932629AbcCKQop (ORCPT ); Fri, 11 Mar 2016 11:44:45 -0500 Date: Fri, 11 Mar 2016 11:44:42 -0500 (EST) Message-Id: <20160311.114442.1933815095495449507.davem@davemloft.net> To: a.hajda@samsung.com Cc: tom@herbertland.com, b.zolnierkie@samsung.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kcm: fix variable type From: David Miller In-Reply-To: <1457679075-22094-1-git-send-email-a.hajda@samsung.com> References: <1457679075-22094-1-git-send-email-a.hajda@samsung.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 11 Mar 2016 08:44:45 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrzej Hajda Date: Fri, 11 Mar 2016 07:51:15 +0100 > Function skb_splice_bits can return negative values, its result should > be assigned to signed variable to allow correct error checking. > > The problem has been detected using patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. > > Signed-off-by: Andrzej Hajda Since skb_splice_bits() returns an 'int', that would be a more appropriate type to use here. Thank you.