[patch] mfd: lp8788-irq: uninitialized variable in irq handler

[patch] mfd: lp8788-irq: uninitialized variable in irq handler

[Dan Carpenter]

Instead to being true/false, the "handled" is true/uninitialized.
Presumably this doesn't cause that many problems in real life because
normally we handle the IRQ.

Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/mfd/lp8788-irq.c b/drivers/mfd/lp8788-irq.c
index c7a9825..792d51b 100644
--- a/drivers/mfd/lp8788-irq.c
+++ b/drivers/mfd/lp8788-irq.c
@@ -112,7 +112,7 @@ static irqreturn_t lp8788_irq_handler(int irq, void *ptr)
 	struct lp8788_irq_data *irqd = ptr;
 	struct lp8788 *lp = irqd->lp;
 	u8 status[NUM_REGS], addr, mask;
-	bool handled;
+	bool handled = false;
 	int i;
 
 	if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))

Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler

[Kim, Milo]

On 3/11/2016 5:11 PM, Dan Carpenter wrote:
> Instead to being true/false, the "handled" is true/uninitialized.
> Presumably this doesn't cause that many problems in real life because
> normally we handle the IRQ.
>
> Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Milo Kim <milo.kim@ti.com>

Thanks for catching this!

>
> diff --git a/drivers/mfd/lp8788-irq.c b/drivers/mfd/lp8788-irq.c
> index c7a9825..792d51b 100644
> --- a/drivers/mfd/lp8788-irq.c
> +++ b/drivers/mfd/lp8788-irq.c
> @@ -112,7 +112,7 @@ static irqreturn_t lp8788_irq_handler(int irq, void *ptr)
>   	struct lp8788_irq_data *irqd = ptr;
>   	struct lp8788 *lp = irqd->lp;
>   	u8 status[NUM_REGS], addr, mask;
> -	bool handled;
> +	bool handled = false;
>   	int i;
>
>   	if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))
>

Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler

[Lee Jones]

On Fri, 11 Mar 2016, Dan Carpenter wrote:

> Instead to being true/false, the "handled" is true/uninitialized.
> Presumably this doesn't cause that many problems in real life because
> normally we handle the IRQ.
> 
> Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

I've fixed the $SUBJECT line to be more consistent with the subsystem
style for you this time.  Please pay more attention to that in the
future.

`git log --oneline -- $SUBSYSTEM` helps with this.

[I think I recall a conversation with you about this before, and you
said it was part of your submission process?]

Patch applied, thanks.
 
> diff --git a/drivers/mfd/lp8788-irq.c b/drivers/mfd/lp8788-irq.c
> index c7a9825..792d51b 100644
> --- a/drivers/mfd/lp8788-irq.c
> +++ b/drivers/mfd/lp8788-irq.c
> @@ -112,7 +112,7 @@ static irqreturn_t lp8788_irq_handler(int irq, void *ptr)
>  	struct lp8788_irq_data *irqd = ptr;
>  	struct lp8788 *lp = irqd->lp;
>  	u8 status[NUM_REGS], addr, mask;
> -	bool handled;
> +	bool handled = false;
>  	int i;
>  
>  	if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler

[Dan Carpenter]

Gar, the truth is I'm never going to remember to capitalize patches for
you.  No one else has that rule.  Plus the last two times we had this
discussion the patches I was fixing were not capitalized either.

git log -p --author="Dan Carpenter" drivers/mfd | grep Fixes | head -n 2

regards,
dan carpenter

Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler

[Lee Jones]

On Mon, 21 Mar 2016, Dan Carpenter wrote:

> Gar, the truth is I'm never going to remember to capitalize patches for
> you.  No one else has that rule.  Plus the last two times we had this

It's an awesome rule.  Everyone should have that rule. ;)

> discussion the patches I was fixing were not capitalized either.
> 
> git log -p --author="Dan Carpenter" drivers/mfd | grep Fixes | head
> -n 2

Not sure what you think the output of this command is meant to show,
but I get this: 

$ git log -p --author="Dan Carpenter" drivers/mfd | grep Fixes | head -n 2
    Fixes: c013f0a56c56 ('mfd: Add pm8xxx irq support')

... which seems to go against your statement.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog