From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbcCKSPJ (ORCPT ); Fri, 11 Mar 2016 13:15:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52135 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbcCKSPD (ORCPT ); Fri, 11 Mar 2016 13:15:03 -0500 Date: Fri, 11 Mar 2016 19:14:58 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Jiri Olsa , Steven Rostedt , lkml , Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling events Message-ID: <20160311181458.GA1060@krava.redhat.com> References: <1457556405-27717-1-git-send-email-jolsa@kernel.org> <1457556405-27717-2-git-send-email-jolsa@kernel.org> <20160310003637.GA21119@sejong> <20160310072502.GA11206@krava.redhat.com> <20160311083624.GB1052@krava.redhat.com> <20160311134814.GA25533@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160311134814.GA25533@danjae.kornet> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 11, 2016 at 10:48:14PM +0900, Namhyung Kim wrote: SNIP > > > > What about checking is_sampling_event() first and goto the last > > > > paranoid_tracepoint_raw check instead? This way we can remove the > > > > same check in the function trace case. > > > > > > right, will check > > > > hum, did you mean something like this? > > > > I'd rather keep it the original way.. seems more straight > > Hmm.. I think I was wrong. But it seems we can simply return 0 for > non sampling case. How about this? yep, that seems better.. will post v2 thanks, jirka