From: Borislav Petkov <bp@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Toshi Kani <toshi.kani@hpe.com>,
Richard Purdie <richard.purdie@linuxfoundation.org>,
Toshi Kani <toshi.kani@hp.com>,
Bruce Ashfield <bruce.ashfield@windriver.com>,
"Hart, Darren" <darren.hart@intel.com>,
"saul.wold" <saul.wold@intel.com>,
linux-kernel@vger.kernel.org, kvm ML <kvm@vger.kernel.org>,
x86-ml <x86@kernel.org>
Subject: Re: runtime regression with "x86/mm/pat: Emulate PAT when it is disabled"
Date: Fri, 11 Mar 2016 23:16:51 +0100 [thread overview]
Message-ID: <20160311221651.GE4347@pd.tnic> (raw)
In-Reply-To: <56E319FF.3090709@redhat.com>
On Fri, Mar 11, 2016 at 08:18:23PM +0100, Paolo Bonzini wrote:
> Somebody got it wrong 10-ish years ago, and nobody has ever checked since.
>
> But, don't use qemu32 or qemu64. Use kvm32 and kvm64, or better
> something like the host you run on ("-cpu Nehalem", "-cpu SandyBridge",
> "-cpu Haswell-noTSX" etc.).
Paul, Richard, how about it?
> I really, really should fix those defaults...
Here's a start, while I have everything fresh in my head.
---
From: Borislav Petkov <bp@suse.de>
Date: Fri, 11 Mar 2016 23:11:05 +0100
Subject: [PATCH] target-i386/cpu: Correct MTRR and PAT feature bits
Pentium Pro had MTRRs but not PAT, PAT support appeared in Pentium III.
Fix all defines.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
target-i386/cpu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 0f38d1eae317..fa7ea4a8c229 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -308,12 +308,12 @@ static const char *cpuid_6_feature_name[] = {
#define PENTIUM_FEATURES (I486_FEATURES | CPUID_DE | CPUID_TSC | \
CPUID_MSR | CPUID_MCE | CPUID_CX8 | CPUID_MMX | CPUID_APIC)
#define PENTIUM2_FEATURES (PENTIUM_FEATURES | CPUID_PAE | CPUID_SEP | \
- CPUID_MTRR | CPUID_PGE | CPUID_MCA | CPUID_CMOV | CPUID_PAT | \
+ CPUID_MTRR | CPUID_PGE | CPUID_MCA | CPUID_CMOV | \
CPUID_PSE36 | CPUID_FXSR)
-#define PENTIUM3_FEATURES (PENTIUM2_FEATURES | CPUID_SSE)
+#define PENTIUM3_FEATURES (PENTIUM2_FEATURES | CPUID_SSE | CPUID_PAT)
#define PPRO_FEATURES (CPUID_FP87 | CPUID_DE | CPUID_PSE | CPUID_TSC | \
CPUID_MSR | CPUID_MCE | CPUID_CX8 | CPUID_PGE | CPUID_CMOV | \
- CPUID_PAT | CPUID_FXSR | CPUID_MMX | CPUID_SSE | CPUID_SSE2 | \
+ CPUID_MTRR | CPUID_FXSR | CPUID_MMX | CPUID_SSE | CPUID_SSE2 | \
CPUID_PAE | CPUID_SEP | CPUID_APIC)
#define TCG_FEATURES (CPUID_FP87 | CPUID_PSE | CPUID_TSC | CPUID_MSR | \
--
2.3.5
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2016-03-11 22:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 20:59 runtime regression with "x86/mm/pat: Emulate PAT when it is disabled" Paul Gortmaker
2016-03-03 21:18 ` Paul Gortmaker
2016-03-04 5:02 ` Toshi Kani
2016-03-04 18:37 ` Paul Gortmaker
2016-03-04 22:12 ` Toshi Kani
2016-03-07 0:35 ` Paul Gortmaker
2016-03-07 16:03 ` Toshi Kani
[not found] ` <20160307210852.GC26051@windriver.com>
2016-03-07 23:38 ` Toshi Kani
2016-03-07 23:53 ` Paul Gortmaker
2016-03-08 0:56 ` Toshi Kani
2016-03-08 1:35 ` Toshi Kani
2016-03-08 3:28 ` Paul Gortmaker
2016-03-08 16:38 ` Toshi Kani
2016-03-10 14:42 ` Paul Gortmaker
2016-03-10 16:49 ` Toshi Kani
2016-03-10 17:20 ` Borislav Petkov
2016-03-10 19:04 ` Paul Gortmaker
2016-03-10 19:19 ` Borislav Petkov
2016-03-11 13:23 ` One Thousand Gnomes
2016-03-11 13:40 ` Borislav Petkov
2016-03-11 19:18 ` Paolo Bonzini
2016-03-11 22:16 ` Borislav Petkov [this message]
2016-03-11 22:28 ` Bruce Ashfield
2016-03-11 23:29 ` Richard Purdie
2016-03-12 12:03 ` Borislav Petkov
2016-03-10 20:12 ` Toshi Kani
2016-03-10 20:04 ` Toshi Kani
2016-03-10 19:20 ` Borislav Petkov
2016-03-10 20:24 ` Toshi Kani
2016-03-10 21:07 ` Borislav Petkov
2016-03-10 23:17 ` Toshi Kani
2016-03-08 3:16 ` Paul Gortmaker
2016-03-08 16:13 ` Toshi Kani
2016-03-08 16:03 ` Paul Gortmaker
2016-03-08 17:01 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311221651.GE4347@pd.tnic \
--to=bp@suse.de \
--cc=bruce.ashfield@windriver.com \
--cc=darren.hart@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pbonzini@redhat.com \
--cc=richard.purdie@linuxfoundation.org \
--cc=saul.wold@intel.com \
--cc=toshi.kani@hp.com \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).