From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH 4/5] ftrace: Make ftrace_hash_rec_enable return update bool
Date: Sat, 12 Mar 2016 17:35:02 +0900 [thread overview]
Message-ID: <20160312083502.GA27257@danjae.kornet> (raw)
In-Reply-To: <20160311181506.GB1060@krava.redhat.com>
Hi Jiri,
On Fri, Mar 11, 2016 at 07:15:06PM +0100, Jiri Olsa wrote:
> On Fri, Mar 11, 2016 at 11:28:00PM +0900, Namhyung Kim wrote:
>
> SNIP
>
> > > @@ -1694,7 +1695,7 @@ static void __ftrace_hash_rec_update(struct ftrace_ops *ops,
> > > if (inc) {
> > > rec->flags++;
> > > if (FTRACE_WARN_ON(ftrace_rec_count(rec) == FTRACE_REF_MAX))
> > > - return;
> > > + return false;
> > >
> > > /*
> > > * If there's only a single callback registered to a
> > > @@ -1720,7 +1721,7 @@ static void __ftrace_hash_rec_update(struct ftrace_ops *ops,
> > > rec->flags |= FTRACE_FL_REGS;
> > > } else {
> > > if (FTRACE_WARN_ON(ftrace_rec_count(rec) == 0))
> > > - return;
> > > + return false;
> > > rec->flags--;
> > >
> > > /*
> > > @@ -1753,22 +1754,27 @@ static void __ftrace_hash_rec_update(struct ftrace_ops *ops,
> > > */
> > > }
> > > count++;
> > > +
> > > + update |= ftrace_test_record(rec, 1) != FTRACE_UPDATE_IGNORE;
> >
> > Shouldn't it use 'inc' instead of 1 for the second argument of
> > the ftrace_test_record()?
>
> I dont think so, 1 is to update calls (FTRACE_UPDATE_CALLS)
> check ftrace_modify_all_code:
>
> if (command & FTRACE_UPDATE_CALLS)
> ftrace_replace_code(1);
> else if (command & FTRACE_DISABLE_CALLS)
> ftrace_replace_code(0);
>
> both ftrace_startup, ftrace_shutdown use FTRACE_UPDATE_CALLS
Ah, ok. So the second argument of the ftrace_test_record() is not
'enable' actually.. :-/
>
> you'd use 0 only to disable all, check ftrace_check_record comments:
>
> /*
> * If we are updating calls:
> *
> * If the record has a ref count, then we need to enable it
> * because someone is using it.
> *
> * Otherwise we make sure its disabled.
> *
> * If we are disabling calls, then disable all records that
> * are enabled.
> */
> if (enable && ftrace_rec_count(rec))
> flag = FTRACE_FL_ENABLED;
>
>
> used by ftrace_shutdown_sysctl
I got it. Thank you for the explanation!
Thanks,
Namhyung
next prev parent reply other threads:[~2016-03-12 8:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 20:46 [RFC 0/5] ftrace perf: Fixes and speedup Jiri Olsa
2016-03-09 20:46 ` [PATCH 1/5] ftrace perf: Check sample types only for sampling events Jiri Olsa
2016-03-10 0:36 ` Namhyung Kim
2016-03-10 7:25 ` Jiri Olsa
2016-03-11 8:36 ` Jiri Olsa
2016-03-11 13:48 ` Namhyung Kim
2016-03-11 18:14 ` Jiri Olsa
2016-03-15 20:06 ` Steven Rostedt
2016-03-15 21:51 ` Jiri Olsa
2016-03-09 20:46 ` [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to init event Jiri Olsa
2016-03-10 0:39 ` Namhyung Kim
2016-03-11 8:39 ` Jiri Olsa
2016-03-09 20:46 ` [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Jiri Olsa
2016-03-10 1:29 ` Namhyung Kim
2016-03-09 20:46 ` [PATCH 4/5] ftrace: Make ftrace_hash_rec_enable return update bool Jiri Olsa
2016-03-11 14:28 ` Namhyung Kim
2016-03-11 18:15 ` Jiri Olsa
2016-03-12 8:35 ` Namhyung Kim [this message]
2016-03-15 19:43 ` Steven Rostedt
2016-03-09 20:46 ` [PATCH 5/5] ftrace: Update dynamic ftrace calls only if necessary Jiri Olsa
2016-03-16 14:34 [PATCHv2 0/5] ftrace perf: Fixes and speedup Jiri Olsa
2016-03-16 14:34 ` [PATCH 4/5] ftrace: Make ftrace_hash_rec_enable return update bool Jiri Olsa
2016-03-17 0:23 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160312083502.GA27257@danjae.kornet \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).