From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753202AbcCNRLH (ORCPT ); Mon, 14 Mar 2016 13:11:07 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47776 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752420AbcCNRLE (ORCPT ); Mon, 14 Mar 2016 13:11:04 -0400 Date: Mon, 14 Mar 2016 13:11:01 -0400 (EDT) Message-Id: <20160314.131101.1124355509776435130.davem@davemloft.net> To: arnd@arndb.de Cc: skhare@vmware.com, pv-drivers@vmware.com, sbhatewara@vmware.com, gyang@vmware.com, nhorman@tuxdriver.com, khoroshilov@ispras.ru, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vmxnet3: fix lock imbalance in vmxnet3_tq_xmit() From: David Miller In-Reply-To: <1457967280-4014226-1-git-send-email-arnd@arndb.de> References: <1457967280-4014226-1-git-send-email-arnd@arndb.de> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 14 Mar 2016 10:11:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 14 Mar 2016 15:53:57 +0100 > A recent bug fix rearranged the code in vmxnet3_tq_xmit() in a > way that left the error handling for oversized headers unlock > a lock that had not been taken yet. Gcc warns about the incorrect > use of the 'flags' variable because of that: > > drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_tq_xmit.constprop': > include/linux/spinlock.h:246:3: error: 'flags' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This changes the error handling path to 'goto' the end of the function > beyond the lock/unlock pair. > > Signed-off-by: Arnd Bergmann > Fixes: cec05562fb1d ("vmxnet3: avoid calling pskb_may_pull with interrupts disabled") Applied and queued up for -stable, thanks.