From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754358AbcCNER6 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Mar 2016 00:17:58 -0400
Received: from LGEAMRELO13.lge.com ([156.147.23.53]:58865 "EHLO
	lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750790AbcCNER5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Mar 2016 00:17:57 -0400
X-Original-SENDERIP: 156.147.1.121
X-Original-MAILFROM: byungchul.park@lge.com
X-Original-SENDERIP: 10.177.222.33
X-Original-MAILFROM: byungchul.park@lge.com
Date: Mon, 14 Mar 2016 13:17:48 +0900
From: Byungchul Park <byungchul.park@lge.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: akpm@linux-foundation.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
        akinobu.mita@gmail.com, jack@suse.cz, peter@hurleysoftware.com,
        tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org
Subject: Re: [PATCH v6 2/2] printk: Make printing of spin_dump() deferred to
 avoid a deadlock
Message-ID: <20160314041747.GF5220@X58A-UD3R>
References: <1457692627-14076-1-git-send-email-byungchul.park@lge.com>
 <1457692627-14076-3-git-send-email-byungchul.park@lge.com>
 <20160314013752.GB8074@swordfish>
 <20160314023030.GE5220@X58A-UD3R>
 <20160314024054.GC8074@swordfish>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160314024054.GC8074@swordfish>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 14, 2016 at 11:40:55AM +0900, Sergey Senozhatsky wrote:
> Hi,
> 
> On (03/14/16 11:30), Byungchul Park wrote:
> [..]
> > > so can it be
> > > 
> > > vprintk_emit()
> > >  __spin_dump_deferred()
> > >   vprintk_deferred()
> > >    vprintk_emit()
> > >     __spin_dump_deferred()
> >       ^^^
> >       can be caused by raw_spin_lock(logbug_lock)
> > 
> > >      vprintk_deferred()
> > 
> > Yes, it can happen by raw_spin_lock(logbuf_lock) to print warning or error
> > message. Are you worrying about an infinite recursion?
> 
> yes.
> 
> > 1. In the case printing warning, eventually it can fill the buffer without
> > actual printing using console.
> 
> so the worry is that the CPU that spins on __spin_dump_deferred() has IRQs
> disabled and `printk_pending' bit set; but IRQ may never be enabled on this
> CPU.

It's true if another cpu never release the logbug_lock. But it's another
problem which current code already has and must be solved by another way.
IOW, the situation where the logbug_lock is not held yet is not the case
where we need to worry about whether the "IRQ work queue" works or not.

> 
> > 2. In the case printing error, the infinite recursion can be prevented by
> > debug_locks_off().
> > 
> > Therefore, no problem.
> 
> 	-ss