From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933981AbcCNJ7S (ORCPT ); Mon, 14 Mar 2016 05:59:18 -0400 Received: from casper.infradead.org ([85.118.1.10]:50973 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbcCNJ7K (ORCPT ); Mon, 14 Mar 2016 05:59:10 -0400 Date: Mon, 14 Mar 2016 10:58:56 +0100 From: Peter Zijlstra To: Suravee Suthikulpanit Cc: joro@8bytes.org, bp@alien8.de, mingo@redhat.com, acme@kernel.org, andihartmann@freenet.de, vw@iommu.org, labbott@redhat.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Message-ID: <20160314095856.GL6344@twins.programming.kicks-ass.net> References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> <56E64B68.3090505@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E64B68.3090505@amd.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 14, 2016 at 12:26:00PM +0700, Suravee Suthikulpanit wrote: > Hi, > > On 03/12/2016 08:22 PM, Peter Zijlstra wrote: > >On Tue, Feb 23, 2016 at 08:12:36AM -0600, Suravee Suthikulpanit wrote: > >>From: Suravee Suthikulpanit > >> > >>First, this patch move arch/x86/events/amd/iommu.h to > >>arch/x86/include/asm/perf/amd/iommu.h so that we easily include > >>it in both perf-amd-iommu and amd-iommu drivers. > >> > >>Then, we consolidate declaration of AMD IOMMU performance counter > >>APIs into one file. > > > >These seem two independent thingies; should this therefore not be 2 > >patches? > > > >>Reviewed-by: Joerg Roedel > >>Signed-off-by: Suravee Suthikulpanit > >>--- > >> arch/x86/events/amd/iommu.c | 2 +- > >> arch/x86/events/amd/iommu.h | 40 --------------------------------- > >> arch/x86/include/asm/perf/amd/iommu.h | 42 +++++++++++++++++++++++++++++++++++ > > > >That seems somewhat excessive. Not only do you create > >arch/x86/include/asm/perf/ you then put another directory on top of > >that. > > > > The original header files (arch/x86/events/amd/iommu.h and > drivers/iommu/amd_iommu_proto.h) has duplicate function declarations. So, > with the new header file being in the arch/x86/include/asm/perf/amd/iommu.h, > we can just have one function declaration. > > So, you just want to separate the file moving part and the part that removes > of the duplication? I'm fine with a new header, it just seems putting it in a two deep direcotry hierarchy of its own that seems excessive.