From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ingo Molnar <mingo@kernel.org>
Cc: Scott Ashcroft <scott.ashcroft@talk21.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Borislav Petkov <bp@alien8.de>,
Ben Hutchings <ben@decadent.org.uk>,
Raphael Hertzog <hertzog@debian.org>,
Roger Shimizu <rogershimizu@gmail.com>,
Alexis Murzeau <amurzeau@gmail.com>
Subject: Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables
Date: Mon, 14 Mar 2016 11:35:02 +0000 [thread overview]
Message-ID: <20160314113502.GC2619@codeblueprint.co.uk> (raw)
In-Reply-To: <20160314103019.GA32573@gmail.com>
On Mon, 14 Mar, at 11:30:19AM, Ingo Molnar wrote:
>
> * Matt Fleming <matt@codeblueprint.co.uk> wrote:
>
> > diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
> > index 8fee5b6f8f66..af74849e8c0f 100644
> > --- a/arch/x86/mm/pageattr.c
> > +++ b/arch/x86/mm/pageattr.c
> > @@ -1055,7 +1055,7 @@ static int populate_pud(struct cpa_data *cpa, unsigned long start, pgd_t *pgd,
> > /*
> > * Map everything starting from the Gb boundary, possibly with 1G pages
> > */
> > - while (end - start >= PUD_SIZE) {
> > + while (cpu_has_gbpages && end - start >= PUD_SIZE) {
> > set_pud(pud, __pud(cpa->pfn << PAGE_SHIFT | _PAGE_PSE |
> > massage_pgprot(pud_pgprot)));
>
> Btw., can 'cpa->pfn << PAGE_SHIFT' possibly work on 32-bit systems?
>
> cpa->pfn is unsigned long, so the result gets truncated to 32 bits ...
>
> cpa->pfn should be u64.
That is a nice catch.
Note that we never run this code on 32-bit right now. Moving 32-bit to
this code and away from the old_map scheme is on my TODO list.
next prev parent reply other threads:[~2016-03-14 11:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 11:19 [GIT PULL] EFI urgent fix for v4.6 queue Matt Fleming
2016-03-11 11:19 ` [PATCH] x86/efi: Always map boot service regions into new EFI page tables Matt Fleming
2016-03-12 18:57 ` [tip:x86/urgent] x86/efi: Fix boot crash by always mapping " tip-bot for Matt Fleming
2016-03-12 23:02 ` Matt Fleming
2016-03-13 17:56 ` Ingo Molnar
2016-03-13 17:09 ` [PATCH] x86/efi: Always map " Scott Ashcroft
2016-03-13 21:58 ` Matt Fleming
2016-03-13 23:07 ` Matt Fleming
2016-03-13 23:44 ` Scott Ashcroft
2016-03-14 1:09 ` Scott Ashcroft
2016-03-14 10:30 ` Ingo Molnar
2016-03-14 11:35 ` Matt Fleming [this message]
2016-03-14 12:05 ` Ingo Molnar
2016-03-14 14:27 ` Matt Fleming
2016-03-14 16:47 ` Ingo Molnar
2016-03-15 15:54 ` Matt Fleming
2016-03-15 16:05 ` Borislav Petkov
2016-03-15 16:25 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314113502.GC2619@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=amurzeau@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=ben@decadent.org.uk \
--cc=bp@alien8.de \
--cc=hertzog@debian.org \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rogershimizu@gmail.com \
--cc=scott.ashcroft@talk21.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).