From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965066AbcCNMVY (ORCPT ); Mon, 14 Mar 2016 08:21:24 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:10919 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964849AbcCNMVQ (ORCPT ); Mon, 14 Mar 2016 08:21:16 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 14 Mar 2016 05:19:49 -0700 Date: Mon, 14 Mar 2016 13:21:05 +0100 From: Thierry Reding To: Andy Yan CC: , , , , , , , , , , , Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y Message-ID: <20160314122104.GF22912@ulmo.nvidia.com> References: <1457787029-9168-1-git-send-email-andy.yan@kernel-upstream.org> <1457787100-9221-1-git-send-email-andy.yan@kernel-upstream.org> MIME-Version: 1.0 In-Reply-To: <1457787100-9221-1-git-send-email-andy.yan@kernel-upstream.org> X-NVConfidentiality: public User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.2.70.46] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5CUMAwwhRxlRszMD" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5CUMAwwhRxlRszMD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 12, 2016 at 08:51:40PM +0800, Andy Yan wrote: > Some platform like Rockchip rk3066 use pwm as a regulator to modulate > cpu voltage, so pwm regulator should be enabled at system boot time if > the system want to run with high frequency. >=20 > Signed-off-by: Andy Yan > --- >=20 > arch/arm/configs/multi_v7_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This really belongs in patch 1/2. But then the same comments hold true and I think you'll need to come up with a proper fix that prevents the switch to a higher frequency if don't have the necessary regulator, or make the Kconfig symbol bool if all else fails. If you make the Kconfig symbol bool I'd expect a really good explanation in the commit message as to why it can't be fixed properly. Thierry --5CUMAwwhRxlRszMD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJW5qywAAoJEN0jrNd/PrOhzCsQAK/igEarI+x/AcSzd1HS0jEy m2wPx/cLaVUkzTp9X/neNgtjcBmNOMoW9vOu30YrL+9wF7a8Sn4D0LTsRKTtVJSg XUqPYkTO4rjx00aC9VwmlHTvsn/64eOM/WTiPyshJgVaKm6qLxAvWfhN3GoF/N/F 6lUQ4buZrwy6U4JFu5MQ7J7hLuiUMdQUuaHSYKTn0OjGwTrYOkNRQQB32fnEfGBd kZS9HW0IUErDHpyY4BdzndSbyz2cIl6IIerF+N3TvVYPfbBjNNrAXAIktGXDrL4b KbdhsbDOL85cQxWcLqNJ+mYPBp5hUumyfQe+fZ0rFDVpwNyVO87YwF0vfU0inVAf d2TSw5CMrIpCxaT1iaL76pC1Tbrhy/aHGGMQZWI3bdZ9yTuXi8v1bM1UVivmV8z+ EwakYQhOLkQz8PY+oms86+0w39eRED8pWyZbOZ1qHZ5ZvP3DhWoBuWfNdZSEOAGe 7qogxd4WXXzB0JjQGsFZPM8x5oiByqc/ijr27P4Z0LvKWQdstXIHaawBTSGA5Kcm TjVOL/9rOGDcUGCympoRn31QXt6MWTk5vN7vH3Ke6rX86TMeR8diZ88hzVPjmTSu H25MD0IqIiMBMquQ/QACkNmK5pW/2DuxlkEhZnC/diEorksVavPLI6XpWXeO81pW 15qhrcdRtpogz+2ls12C =DHSF -----END PGP SIGNATURE----- --5CUMAwwhRxlRszMD--