From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934253AbcCNMp2 (ORCPT ); Mon, 14 Mar 2016 08:45:28 -0400 Received: from mail-bn1bon0057.outbound.protection.outlook.com ([157.56.111.57]:36290 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752512AbcCNMpV (ORCPT ); Mon, 14 Mar 2016 08:45:21 -0400 X-Greylist: delayed 11248 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Mar 2016 08:45:21 EDT Authentication-Results: the-dreams.de; dkim=none (message not signed) header.d=none;the-dreams.de; dmarc=none action=none header.from=caviumnetworks.com; Date: Mon, 14 Mar 2016 13:45:05 +0100 From: Jan Glauber To: Wolfram Sang CC: , , David Daney , Peter Swain Subject: Re: [PATCH v3 05/14] i2c-octeon: Make adapter timeout tunable Message-ID: <20160314124505.GA5771@hardcore> References: <00a182c50af211e409f128630ba6ba5359da6198.1457362545.git.jglauber@cavium.com> <20160312154611.GH1661@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160312154611.GH1661@katana> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [88.66.101.161] X-ClientProxiedBy: DB4PR07CA027.eurprd07.prod.outlook.com (10.242.229.37) To SN2PR0701MB768.namprd07.prod.outlook.com (25.160.15.146) X-MS-Office365-Filtering-Correlation-Id: 321998d6-9ce2-43c7-ff90-08d34c067fe4 X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;2:BzScTdRul0Vhtt3L30rrUklj9RoqyLxNzZbuSz8HyzAgvrcCXpiLmA0+Wy0Dkc6ML9ToctP50aze33mzwbHym2T44rwfBRNGfjQDFglUNV8z2brxsYbphAWLAKjehC1ix2ezS6OWt6T8iyYVoejawzF5H6Q4IkRVE0V2h2KdSOWsqdoJuZfxbtifype6v9bN;3:2pX5vS9W/6y6+h6MVIala12ZLvIJujUibd1MQYIrgBBOM43VX8WqhOj+SojuagZj8fVP19L7ptzjpJrDAj21Fk8MR38JUoWqgwYZ7sXCeUMRIjTxWapOVuIe2ni40DXs;25:WogFt9p0OR3H+y3dWvN+FbzobujgxurNS7Kn2WNNm+OdUFBJDyoLW9xmpOPFB6urDvOiipHgwnT1y6aeZsSXAkx6QTSjLwzUW4VEVLSnDn8+4mOZkOJiMihlSnmvOCr/vtDpnXv8ABueJbf7WfGkL8QQsuupiX6TjeCPetCWyFUwcOg9q5YOghc5EVwMwdrez+35rkE9i31KMB7rBCgsa3hiHBL0jNRZh4R73i6moyNFFxgkL9TD4D6J1iQiZpTgatEEsmWGtcy7s4JfZvPb1iShOeaR+gUzq3i3d44bVpArDqI5WM6JXC4psS2P4Ca2PV7h6ZG5NjiYcKgrhR2Llw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0701MB768; X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;20:zgBTI8/Y84ABWTZOdQUgMAZrvoWLA+aEjTnuHcTMpBkqs3vq/8QtyPYEgv2sW/XIfL/yXpIu5IWsAaKSQEabQTbc2TyywZ2C/krty6zEZ5wIMObrr7MnbqazfNfxS6BtMsS8gdQ8YCSGFfmVFwHzbcMAiVoyiJAo+8Qzw9eVEJNzNyaANlHQ/cqt5ZzTwzaCkKjbap9V7Gw25MSHzuHR5X59Rk95Xmwn0jt0Zp9uD575kaff8641dX7cnTECFzf7tq+U2DqK4SASEoHy/XsRAVEOHH3uA1D1WZBirx1s9uoWAZRAdYY5awdtAqKuz3A76WZqYARMo+9EyDhe5KX2v2hgjoL1pzcg41gSRSrK9c0TPefKtx/Pm1OLkaZ0bptI23QCTP1RPLJXxKc8vFmC8xNAm8oFx6u04N0FNNZS0xG/m0G3tj5Jo5nCozxkJm1oes3eYimPL6d9eCQK+QunnnaiCNxNJydvMSmUbU0iprlI6Trgb/gehVidNeix7Ul1XDczOhdH/Jn+esjm8i5NuimE0q0lsNpQY3yHjEYpTnGoQ5ZAgc6ICDZzorNP1NrkfAwqtCEB0PJrt02u2jUaQIrywCfCza6xf8Ek/ziLcVs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:SN2PR0701MB768;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0701MB768; X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;4:RQtNwMTEmlGbaJNCUb+mrTnTyFKf1FzUtLF9uEwyT1jRSwlOiUIhtbH24YnyBWdQFSX4eG2FAtqDddp0iOBfxUTJRa+ljhUe3OFfgn7htcD2+vcXMynXfIoY8vshYuq2DzG8oaKt6Zyx3BlhdddMEv7xf4iPvaijEuiFdeE5MsHFQJGK2z/pzfCVjts9SRJBOrfy+3XzmFJjPE2VE0j6VrsBmCveFCzx7RPdRLNqemDr1vf7XsrO+ww/DepCNhrWXo0HBIO9MO29EJIKLK9Rl06qisOZZZXRAkuBllRnR0Fd+njuvwwWh/zOGbdfrFIwGvWkKK1B9AY1OfTp02XJ1tevfLvdv2KI4JBlJTBLuUqB10Ux2std7auruUoMKQ56 X-Forefront-PRVS: 0881A7A935 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(110136002)(50466002)(33716001)(77096005)(2950100001)(4001350100001)(1096002)(19580405001)(189998001)(97756001)(86362001)(76176999)(92566002)(54356999)(46406003)(50986999)(83506001)(66066001)(19580395003)(47776003)(33656002)(42186005)(23726003)(586003)(3846002)(5004730100002)(2906002)(1076002)(6116002)(81166005)(5008740100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR0701MB768;H:hardcore;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;23:1aeH+Ik9lF6Df8bV0GWkXWkWFGjmkWxij/V/sRhUoXk5dVhLRPFBbPbUd5f1TlDX5ZcczZYQPQzrnoU+xU1OZfkIJN2aFp1L83CHxyfIVX4olqvOXFbTj2QqR7cMJ1ck9Xn+QyfV1p78Eyi0ixcedDL+gskTerl1eoRd2dradbVfKFWJGlkNemdvbrKERTvkG6d9wpy+IfAFqEoAXSl88oFino9Zn8u1S8T/Atrx0ta2OyEed7s/CKZN9WraIwuYZ5dpqeE/EEvHwXTZcC4Ibxng7hMYTNIfd3lkVKuSu92wpblHU8QOaoO20GmeNWj3UmL9pIs10ykO8THYmOgg3eOG9cbaCHEoCOU6i/Auk9s/XnTlOf4dx1yDwGGy+MLQOuE6sVs54BCyhbExrS2QwcfcqQ0/J8D+A4t3jFlVB0R1NmiTN95DmVcMpTi8UAtrWQikI1QfpSCA2xBmV5WHfZx5Ql4TpsDZDZcQTcbMTVrUx1UMHqzMyDHS0NADP1s1z/Nn4tzbIpAXN0bOeX2/GR5ZH8cq/lqdlHqk455qCHOrYcNPDVY0VOSVGxSEPzvOmR5VqoPH0hvc4A+O7Gyf3B+0OCyVcVCFQoNYb/3vFPvb+GQNXqm3a/YMjjwZl6z5AMplvSH1npu8O58lcDJnV4LZTg/1W5f5oITy2Q2Y1b5JsaWMP/GH68zUkwxxqwUYsPCf5UUhzmXKOJ5l41+a7zdxWZA5HYOij404e+J0vBeSroa29a6IXAaR5rD79UH3Y4/XZDBPQWQuGiyIM62qo/eI8XFsb1kIdUmfwtAj+4kqmyIgR/oklNvufTLlWaYpjPPkFp50Rdc9neSQAOGjjIftY0aQvANB7rFcBj1ajfG/k6kiB245sFUdxafJIqY+QPjZLdPY+JByjRNIbojBm/dtKbZnEd9FIZj3cyijelY= X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;5:LHbGQ32Yk5YEpQaQu1fuqL/7ai4yc/kvtVE+xg+9d0meRt4k3W6hwKqICOuuRErJvO4loZdztTi/I26zF5kX5cQGzwDtE88rDSPTWXioXDQ8xOUATLZLpTfBzXR1y4+j02wHIood9AflgQA7q4UIDg==;24:oOTh8e8R5B1czfWeKahjjZaFIqqbzYDKOocM1zuFE6r8n6S1BtT4JyfTkYuQ7yCghIm2uNHFuBPgZujO05b8Bxoa4rYGVwr7vPyWR50moSY= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2016 12:45:17.4538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0701MB768 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 12, 2016 at 04:46:12PM +0100, Wolfram Sang wrote: > On Mon, Mar 07, 2016 at 04:10:48PM +0100, Jan Glauber wrote: > > From: Peter Swain > > > > Make the i2c adapter timeout a module parameter to allow upper-level > > target device drivers to retry with their own logic before their own > > timeouts abort operations. > > > > For example, at24 eeprom driver retries for 25ms when -EAGAIN > > indicates that an eeprom has gone unresponsive while committing > > a newly written page (5ms on typical devices). > > > > Signed-off-by: Peter Swain > > Signed-off-by: Jan Glauber > > i2c-dev has IOCTLs for timeout and retries. Can't you use those? > Yes, with these IOCTLs we don't need to add a module parameter so I'll drop that.