From: Peter Zijlstra <peterz@infradead.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: tglx@linutronix.de, mingo@kernel.org, bigeasy@linutronix.de,
umgwanakikbuti@gmail.com, paulmck@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 2/3] rtmutex: Add rt_mutex_init_waiter helper
Date: Mon, 14 Mar 2016 14:16:21 +0100 [thread overview]
Message-ID: <20160314131621.GX6356@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1457461223-4301-3-git-send-email-dave@stgolabs.net>
On Tue, Mar 08, 2016 at 10:20:22AM -0800, Davidlohr Bueso wrote:
> +++ b/kernel/futex.c
> @@ -2778,10 +2778,7 @@ static int futex_wait_requeue_pi(u32 __user *uaddr, unsigned int flags,
> * The waiter is allocated on our stack, manipulated by the requeue
> * code while we sleep on uaddr.
> */
> - debug_rt_mutex_init_waiter(&rt_waiter);
> - RB_CLEAR_NODE(&rt_waiter.pi_tree_entry);
> - RB_CLEAR_NODE(&rt_waiter.tree_entry);
> - rt_waiter.task = NULL;
> + rt_mutex_init_waiter(&rt_waiter);
>
> ret = get_futex_key(uaddr2, flags & FLAGS_SHARED, &key2, VERIFY_WRITE);
> if (unlikely(ret != 0))
> +static inline void
> +rt_mutex_init_waiter(struct rt_mutex_waiter *waiter)
> +{
> + debug_rt_mutex_init_waiter(waiter);
> +
> + RB_CLEAR_NODE(&waiter->pi_tree_entry);
> + RB_CLEAR_NODE(&waiter->tree_entry);
> + waiter->task = NULL;
> +}
Just thinking, would not something like:
#define DEFINE_RT_WAITER(name) \
struct rt_mutex_waiter name = { \
.tree_entry = __INIT_RB_NODE(name.tree_entry), \
.pi_tree_entry = __INIT_RB_NODE(name.pi_tree_entry), \
__INIT_RT_WAITER_DEBUG(name) \
}
Be nicer? That way we're sure the whole structure is initialized.
next prev parent reply other threads:[~2016-03-14 13:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 18:20 [PATCH -tip 0/3] locking/rtmutex: Another crack at spin on owner Davidlohr Bueso
2016-03-08 18:20 ` [PATCH 1/3] rtmutex: Delete save_state member of struct rt_mutex Davidlohr Bueso
2016-03-08 18:20 ` [PATCH 2/3] rtmutex: Add rt_mutex_init_waiter helper Davidlohr Bueso
2016-03-14 13:16 ` Peter Zijlstra [this message]
2016-03-08 18:20 ` [PATCH 3/3] rtmutex: Reduce top-waiter blocking on a lock Davidlohr Bueso
2016-03-14 13:23 ` Peter Zijlstra
2016-03-08 22:05 ` [PATCH 4/3] rtmutex: Avoid barrier in rt_mutex_handle_deadlock Davidlohr Bueso
2016-03-14 13:40 ` Peter Zijlstra
2016-03-21 18:16 ` Davidlohr Bueso
2016-03-22 10:21 ` Peter Zijlstra
2016-03-22 11:32 ` Heiko Carstens
2016-03-22 12:20 ` Peter Zijlstra
2016-03-22 13:26 ` Heiko Carstens
2016-03-22 13:55 ` Peter Zijlstra
2016-03-22 14:45 ` Heiko Carstens
2016-03-22 16:41 ` Peter Zijlstra
2016-03-22 21:46 ` Heiko Carstens
2016-03-25 2:30 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314131621.GX6356@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).