From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965338AbcCNPCz (ORCPT ); Mon, 14 Mar 2016 11:02:55 -0400 Received: from mga04.intel.com ([192.55.52.120]:33680 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965422AbcCNPCu (ORCPT ); Mon, 14 Mar 2016 11:02:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,335,1455004800"; d="scan'208";a="936737853" Date: Mon, 14 Mar 2016 17:02:14 +0200 From: Mika Westerberg To: Irina Tirdea Cc: Lee Jones , linux-kernel@vger.kernel.org, Andy Shevchenko , "Rafael J. Wysocki" , Octavian Purdila Subject: Re: [PATCH 1/1] mfd: core: fix ACPI child matching by _HID/_CID Message-ID: <20160314150214.GL1793@lahna.fi.intel.com> References: <1457830978-17494-1-git-send-email-irina.tirdea@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457830978-17494-1-git-send-email-irina.tirdea@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 13, 2016 at 03:02:58AM +0200, Irina Tirdea wrote: > If MDF child devices have separate ACPI nodes identified > by _HID/_CID, they will not be assigned the intended > ACPI companion. > > acpi_match_device_ids will return 0 if a the child device > matches the _HID/_CID, so this patch changes the matching > condition to check for 0 on success. > > Signed-off-by: Irina Tirdea Good catch! Acked-by: Mika Westerberg