From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934570AbcCOKxr (ORCPT ); Tue, 15 Mar 2016 06:53:47 -0400 Received: from casper.infradead.org ([85.118.1.10]:51962 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932585AbcCOKxi (ORCPT ); Tue, 15 Mar 2016 06:53:38 -0400 Date: Tue, 15 Mar 2016 11:53:18 +0100 From: Peter Zijlstra To: Borislav Petkov Cc: Suravee Suthikulpanit , joro@8bytes.org, mingo@redhat.com, acme@kernel.org, andihartmann@freenet.de, vw@iommu.org, labbott@redhat.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Message-ID: <20160315105318.GU6344@twins.programming.kicks-ass.net> References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> <56E64B68.3090505@amd.com> <20160314095856.GL6344@twins.programming.kicks-ass.net> <56E6BE7E.8010807@amd.com> <20160314141945.GE15800@pd.tnic> <20160314163913.GO6344@twins.programming.kicks-ass.net> <56E759C3.5040707@amd.com> <20160315104017.GA4559@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160315104017.GA4559@pd.tnic> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 15, 2016 at 11:40:17AM +0100, Borislav Petkov wrote: > On Tue, Mar 15, 2016 at 07:39:31AM +0700, Suravee Suthikulpanit wrote: > > What if I just merge the newly introduced arch/x86/include/perf/amd/iommu.h > > into the include/linux/amd-iommu.h? I do not see the point of having to > > separate things out into two files. > > Except that this header has x86-specific stuff and include/linux/ is > arch-agnostic. Which would suggest that header is placed wrong, because I would expect the amd-iommu to really be rather x86 specific. Or is AMD making ARM parts for which this is useful too?