From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] atomic: Fix bugs in 'fetch_or()' and rename it to 'xchg_or()'
Date: Tue, 15 Mar 2016 12:06:33 +0100 [thread overview]
Message-ID: <20160315110633.GV6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160315093245.GA7943@gmail.com>
On Tue, Mar 15, 2016 at 10:32:45AM +0100, Ingo Molnar wrote:
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index 969e6704c3c9..851631899352 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -264,7 +264,7 @@ static void tick_nohz_dep_set_all(unsigned long *dep,
> {
> unsigned long prev;
>
> - prev = fetch_or(dep, BIT_MASK(bit));
> + prev = xchg_or(dep, BIT_MASK(bit));
> if (!prev)
> tick_nohz_full_kick_all();
> }
> @@ -294,7 +294,7 @@ void tick_nohz_dep_set_cpu(int cpu, enum tick_dep_bits bit)
>
> ts = per_cpu_ptr(&tick_cpu_sched, cpu);
>
> - prev = fetch_or(&ts->tick_dep_mask, BIT_MASK(bit));
> + prev = xchg_or(&ts->tick_dep_mask, BIT_MASK(bit));
> if (!prev) {
> preempt_disable();
> /* Perf needs local kick that is NMI safe */
Those should probably also use BIT(), BIT_MASK() is specifically for
bitmasks, and should be combined with BIT_WORD().
next prev parent reply other threads:[~2016-03-15 11:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 12:32 [GIT PULL] NOHZ updates for v4.6 Ingo Molnar
2016-03-15 2:44 ` Linus Torvalds
2016-03-15 8:42 ` Peter Zijlstra
2016-03-15 9:49 ` Ingo Molnar
2016-03-15 9:32 ` [PATCH] atomic: Fix bugs in 'fetch_or()' and rename it to 'xchg_or()' Ingo Molnar
2016-03-15 10:50 ` Peter Zijlstra
2016-03-15 12:08 ` Ingo Molnar
2016-03-15 12:42 ` Peter Zijlstra
2016-03-15 11:06 ` Peter Zijlstra [this message]
2016-03-15 11:59 ` Peter Zijlstra
2016-03-15 12:01 ` Ingo Molnar
2016-03-15 12:32 ` Ingo Molnar
2016-03-15 12:37 ` Ingo Molnar
2016-03-15 13:17 ` Peter Zijlstra
2016-03-15 12:21 ` [PATCH v2] " Ingo Molnar
2016-03-15 13:26 ` Peter Zijlstra
2016-03-16 8:04 ` Ingo Molnar
2016-03-16 8:29 ` Peter Zijlstra
2016-03-15 17:08 ` Frederic Weisbecker
2016-03-16 8:14 ` Ingo Molnar
2016-03-17 0:54 ` Frederic Weisbecker
2016-03-15 16:18 ` [PATCH] " Linus Torvalds
2016-03-15 9:53 ` [PATCH] nohz: Change tick_dep_mask from 'unsigned long' to 'unsigned int' Ingo Molnar
2016-03-15 12:15 ` Ingo Molnar
2016-03-15 16:30 ` Linus Torvalds
2016-03-15 17:28 ` Frederic Weisbecker
2016-03-15 17:36 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315110633.GV6344@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).