From: Gustavo Padovan <gustavo@padovan.org>
To: Joe Perches <joe@perches.com>
Cc: "Rob Clark" <robdclark@gmail.com>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Daniel Stone" <daniels@collabora.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Greg Hackmann" <ghackmann@google.com>,
"John Harrison" <John.C.Harrison@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@intel.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()
Date: Thu, 17 Mar 2016 19:16:19 -0300 [thread overview]
Message-ID: <20160317221619.GA11578@joana> (raw)
In-Reply-To: <1458250430.9556.39.camel@perches.com>
2016-03-17 Joe Perches <joe@perches.com>:
> On Thu, 2016-03-17 at 18:19 -0300, Gustavo Padovan wrote:
> > 2016-03-17 Joe Perches <joe@perches.com>:
> > > On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
> > > > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches <joe@perches.com> wrote:
> > > []
> > > > > It's a name that seems like it should be a straightforward
> > > > > cast of a kernel pointer to a __user pointer like:
> > > > >
> > > > > static inline void __user *to_user_ptr(void *p)
> > > > > {
> > > > > return (void __user *)p;
> > > > > }
> > > > ahh, ok. I guess I was used to using it in the context of ioctl
> > > > structs.. in that context u64 -> (void __user *) made more sense.
> > > >
> > > > Maybe uapi_to_ptr()? (ok, not super-creative.. maybe someone has a
> > > > better idea)
> > > Maybe u64_to_user_ptr?
> > That is a good name. If everyone agrees I can resend this patch
> > changing it to u64_to_user_ptr. Then should we still keep it on
> > kernel.h?
>
> I've no particular opinion about location,
> but maybe compat.h might be appropriate.
I don't think this is really related to compat. I'd keep kernel.h.
The problem I'm trying to solve here is:
CC drivers/dma-buf/sync_file.o
drivers/dma-buf/sync_file.c: In function ‘sync_file_ioctl_fence_info’:
drivers/dma-buf/sync_file.c:341:19: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
if (copy_to_user((void __user *)info.sync_fence_info, fence_info,
where info.sync_fence_info is __u64.
Gustavo
next prev parent reply other threads:[~2016-03-17 22:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 17:30 [PATCH v9 1/3] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
2016-03-17 17:30 ` [PATCH v9 2/3] kernel.h: add to_user_ptr() Gustavo Padovan
2016-03-17 17:41 ` Joe Perches
2016-03-17 18:05 ` Gustavo Padovan
2016-03-17 18:43 ` Gustavo Padovan
2016-03-17 20:22 ` Joe Perches
2016-03-17 20:33 ` Rob Clark
2016-03-17 20:40 ` Joe Perches
2016-03-17 20:50 ` Rob Clark
2016-03-17 21:10 ` Joe Perches
2016-03-17 21:19 ` Gustavo Padovan
2016-03-17 21:25 ` Rob Clark
2016-03-17 21:33 ` Joe Perches
2016-03-17 22:16 ` Gustavo Padovan [this message]
2016-03-18 8:23 ` Daniel Vetter
2016-03-17 17:30 ` [PATCH v9 3/3] staging/android: refactor SYNC IOCTLs Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317221619.GA11578@joana \
--to=gustavo@padovan.org \
--cc=John.C.Harrison@intel.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=benh@kernel.crashing.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=riandrews@android.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).