From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757010AbcCRLdx (ORCPT ); Fri, 18 Mar 2016 07:33:53 -0400 Received: from mail.skyhub.de ([78.46.96.112]:56370 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbcCRLds (ORCPT ); Fri, 18 Mar 2016 07:33:48 -0400 Date: Fri, 18 Mar 2016 12:33:44 +0100 From: Borislav Petkov To: Joerg Roedel Cc: Suravee Suthikulpanit , Peter Zijlstra , mingo@redhat.com, acme@kernel.org, andihartmann@freenet.de, vw@iommu.org, labbott@redhat.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Message-ID: <20160318113344.GE7817@pd.tnic> References: <56E759C3.5040707@amd.com> <20160315104017.GA4559@pd.tnic> <20160315105318.GU6344@twins.programming.kicks-ass.net> <56EBA92D.7010906@amd.com> <20160318090441.GA7817@pd.tnic> <56EBC5CD.7070701@amd.com> <20160318092910.GC7817@pd.tnic> <56EBD31F.6050206@amd.com> <20160318103918.GD7817@pd.tnic> <20160318111100.GG2195@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160318111100.GG2195@8bytes.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 18, 2016 at 12:11:01PM +0100, Joerg Roedel wrote: > On Fri, Mar 18, 2016 at 11:39:18AM +0100, Borislav Petkov wrote: > > Yeah, so arch/x86/include/asm/ has all the x86-specific stuff which is > > not exported to userspace, so moving stuff there makes sense to me. > > While the AMD IOMMU is only available on x86 today, there is nothing > x86-specific in its architecture, so I don't think its header files > belong to arch/x86. > > By that reasoning we could also move all of the intel gpu stuff to > arch/x86. But we don't do it, because it doesn't make sense and because > it doesn't belong there. And according to that argument of yours, we should move everything which is not too close to the arch it is being used on, to generic include/linux/. Because it might possibly get used some day by other arches. Yeah right. And looking at include/linux - it looks like a dumping ground for headers. :-\ I guess anything is better than putting non-generic enough stuff in include/linux/. Maybe drivers/include or something in that direction would be better... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.