From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Jiri Olsa <jolsa@kernel.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
patchwork-lst@pengutronix.de, Wang Nan <wangnan0@huawei.com>,
acme@kernel.org
Subject: Re: [PATCH] tools lib api: respect CROSS_COMPILE for the linker
Date: Fri, 18 Mar 2016 12:42:59 -0500 [thread overview]
Message-ID: <20160318174259.4z5s6t2ochryeade@treble.redhat.com> (raw)
In-Reply-To: <20160318173852.GD2701@redhat.com>
On Fri, Mar 18, 2016 at 02:38:52PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 18, 2016 at 12:16:23PM -0500, Josh Poimboeuf escreveu:
> > On Fri, Mar 18, 2016 at 01:45:22PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Fri, Mar 18, 2016 at 11:38:15AM -0500, Josh Poimboeuf escreveu:
> > > > On Fri, Mar 18, 2016 at 01:25:47PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Which is different from what the kernel does in its main Makefile:
>
> > > # Make variables (CC, etc...)
> > > AS = $(CROSS_COMPILE)as
> > > LD = $(CROSS_COMPILE)ld
> > > CC = $(CROSS_COMPILE)gcc
>
> > > I wonder if we could settle in one of these styles or if there is really
> > > a reason to be creative :-)
>
> > > Better, all this could go to tools/scripts/Makefile.include?
>
> > Yeah, I agree that it would be good to come up with a common and
> > consistent approach tools-wide if possible.
>
> <SNOP>
> > So 'allow-override' would probably be a good option.
>
> Humm, my preference is to make tools/ look like the kernel, and the
> kernel doesn't use that allow-override thing, right? So perhaps add what
> is missing to make it look exactly like the kernel and then ditch this
> allow-override thing?
To achieve that I think the 'hostprogs' stuff would also need to be
ported over. Not sure how much work that would be.
> What about having all this in a single place in tools/script/?
Having it in a single place sounds good to me.
--
Josh
next prev parent reply other threads:[~2016-03-18 17:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 17:27 [PATCH] tools lib api: respect CROSS_COMPILE for the linker Lucas Stach
2016-03-18 16:25 ` Arnaldo Carvalho de Melo
2016-03-18 16:38 ` Josh Poimboeuf
2016-03-18 16:43 ` Josh Poimboeuf
2016-03-18 17:39 ` Arnaldo Carvalho de Melo
2016-03-18 16:45 ` Arnaldo Carvalho de Melo
2016-03-18 17:16 ` Josh Poimboeuf
2016-03-18 17:38 ` Arnaldo Carvalho de Melo
2016-03-18 17:42 ` Josh Poimboeuf [this message]
2016-03-21 8:08 ` Jiri Olsa
2016-03-21 20:40 ` Arnaldo Carvalho de Melo
2016-03-22 7:10 ` Jiri Olsa
2016-03-22 12:50 ` Steven Rostedt
2016-03-22 14:42 ` Arnaldo Carvalho de Melo
2016-03-22 18:22 ` David Sharp
2016-03-22 18:38 ` David Sharp
2016-06-01 9:18 ` Lucas Stach
2016-06-01 13:07 ` Arnaldo Carvalho de Melo
2016-06-08 8:37 ` [tip:perf/core] tools lib api: Respect " tip-bot for Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318174259.4z5s6t2ochryeade@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).