From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753263AbcCUIJI (ORCPT ); Mon, 21 Mar 2016 04:09:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43501 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753041AbcCUII4 (ORCPT ); Mon, 21 Mar 2016 04:08:56 -0400 Date: Mon, 21 Mar 2016 09:08:52 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Josh Poimboeuf , Lucas Stach , Jiri Olsa , linux-kernel@vger.kernel.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de, Wang Nan , acme@kernel.org Subject: Re: [PATCH] tools lib api: respect CROSS_COMPILE for the linker Message-ID: <20160321080852.GC3788@krava.brq.redhat.com> References: <1458235670-27341-1-git-send-email-l.stach@pengutronix.de> <20160318162547.GA2701@redhat.com> <20160318163815.qe7f7cwzis4riwnj@treble.redhat.com> <20160318164522.GB2701@redhat.com> <20160318171623.mih7ozxyinn33ads@treble.redhat.com> <20160318173852.GD2701@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160318173852.GD2701@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 18, 2016 at 02:38:52PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Mar 18, 2016 at 12:16:23PM -0500, Josh Poimboeuf escreveu: > > On Fri, Mar 18, 2016 at 01:45:22PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Fri, Mar 18, 2016 at 11:38:15AM -0500, Josh Poimboeuf escreveu: > > > > On Fri, Mar 18, 2016 at 01:25:47PM -0300, Arnaldo Carvalho de Melo wrote: > > > Which is different from what the kernel does in its main Makefile: > > > > # Make variables (CC, etc...) > > > AS = $(CROSS_COMPILE)as > > > LD = $(CROSS_COMPILE)ld > > > CC = $(CROSS_COMPILE)gcc > > > > I wonder if we could settle in one of these styles or if there is really > > > a reason to be creative :-) > > > > Better, all this could go to tools/scripts/Makefile.include? > > > Yeah, I agree that it would be good to come up with a common and > > consistent approach tools-wide if possible. > > > > So 'allow-override' would probably be a good option. > > Humm, my preference is to make tools/ look like the kernel, and the > kernel doesn't use that allow-override thing, right? So perhaps add what > is missing to make it look exactly like the kernel and then ditch this > allow-override thing? Steven explained his reason for allow-override in the comment above it, please make sure the new solution follows that > > What about having all this in a single place in tools/script/? maybe tools/script/Makefile.comp jirka