From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757531AbcC2Pnp (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Mar 2016 11:43:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42129 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757513AbcC2Pnm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Mar 2016 11:43:42 -0400
Date: Tue, 29 Mar 2016 12:43:39 -0300
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>, linux-kernel@vger.kernel.org,
        mingo@elte.hu, ak@linux.intel.com, kan.liang@intel.com,
        jolsa@redhat.com, namhyung@kernel.org, vincent.weaver@maine.edu
Subject: Re: [PATCH] perf/core: Fix time tracking bug with multiplexing
Message-ID: <20160329154339.GB31342@redhat.com>
References: <1459215203-12885-1-git-send-email-eranian@google.com>
 <20160329072644.GB3408@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160329072644.GB3408@twins.programming.kicks-ass.net>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Mar 29, 2016 at 09:26:44AM +0200, Peter Zijlstra escreveu:
> On Tue, Mar 29, 2016 at 03:33:23AM +0200, Stephane Eranian wrote:
> > This patch fixes a bug introduced by:
> > 
> > commit 3cbaa59069677920186dcf502632ca1df4329f80
> > Author: Peter Zijlstra <peterz@infradead.org>
> > Date:   Wed Feb 24 18:45:47 2016 +0100
> > 
> >     perf: Fix ctx time tracking by introducing EVENT_TIME
> 
> Normal quoting style is:
> 
>   3cbaa5906967 ("perf: Fix ctx time tracking by introducing EVENT_TIME")
> 
> I have the following git alias to help with that:
> 
>   one = show -s --pretty='format:%h (\"%s\")'

Cool, for completeness sake:

  $ git config --global alias.one "show -s --pretty='format:%h (\"%s\")'"
  $ git one 3cbaa59069677920186dcf502632ca1df4329f80
  3cbaa5906967 ("perf: Fix ctx time tracking by introducing EVENT_TIME") 

Make sure you have this in place:

  $ git config --global core.abbrev 12

I also have this, FWIW:

  $ cat ~/bin/fixes
  #!/bin/bash

  if [ $# -eq 1 ] ; then
	cset=$1
  else
	read cset
  fi
  git show --pretty=fuller $cset | grep '^\(Author\|Commit\): ' | sed -r 's/.*: +/Cc: /g'
  echo "Fixes: " `git one $cset`
  $ vim ~/bin/fixes 
  $ fixes 3cbaa59069677920186dcf502632ca1df4329f80
  Cc: Peter Zijlstra <peterz@infradead.org>
  Cc: Ingo Molnar <mingo@kernel.org>
  Fixes 3cbaa5906967 ("perf: Fix ctx time tracking by introducing EVENT_TIME")
  $

So that, in vim, I can select the changeset, then do: ":'<,'>!fixes", so
that the author and commiter of the fixed cset gets on the CC list.

- Arnaldo