From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andres Freund <andres@anarazel.de>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: "perf hists browser: Support flat callchains" appears to have broken parent reporting
Date: Wed, 30 Mar 2016 10:46:34 -0300 [thread overview]
Message-ID: <20160330134634.GA3420@kernel.org> (raw)
In-Reply-To: <20160330123418.GC12336@awork2.anarazel.de>
Em Wed, Mar 30, 2016 at 02:34:18PM +0200, Andres Freund escreveu:
> Hi,
>
> 4b3a3212233a - "perf hists browser: Support flat callchains" seems to
> have broken callchain display in tui mode when using !flat mode, or at
> least changed it in an unintended manner.
humm, at first I thought this would be related to --percent-limit...
What tree/branch are you using? Can you try pressing 'L' to play with
the percent limit?
- Arnaldo
> Llooking at the same perf.data file:
> perf report --tui --no-children -g
> before:
> - 16.69% swapper [kernel.kallsyms] [k] poll_idle
> - poll_idle
> + 16.65% cpuidle_enter_state
> + 0.04% cpuidle_enter
> - 3.51% swapper [kernel.kallsyms] [k] intel_idle
> - intel_idle
> + 3.49% cpuidle_enter_state
> + 0.03% cpuidle_enter
> - 1.35% postgres postgres [.] hash_search_with_hash_value
> - hash_search_with_hash_value
> - 0.32% BufTableLookup
> + ReadBuffer_common
> - 0.18% LockAcquireExtended
> + 0.16% LockRelationOid
> + 0.02% XactLockTableInsert
> + 0.14% FetchPreparedStatement
> + 0.13% CreatePortal
> + 0.11% RelationIdGetRelation
> + 0.10% GetPortalByName
> after:
> - 16.69% swapper [kernel.kallsyms] [k] poll_idle
> poll_idle
> - 3.51% swapper [kernel.kallsyms] [k] intel_idle
> intel_idle
> - 1.35% postgres postgres [.] hash_search_with_hash_value
> hash_search_with_hash_value
> - 1.18% postgres postgres [.] AllocSetAlloc
> AllocSetAlloc
> - 0.85% postgres libc-2.22.so [.] __memcpy_sse2_unaligned
> __memcpy_sse2_unaligned
>
> as you can see after the aforementioned commit there's only one level of
> callers reported.
>
> --stdio output isn't affected.
>
> I can provide an example perf.data file, but it apears to reproduce with
> just about any profile here.
>
> Greetings,
>
> Andres Freund
next prev parent reply other threads:[~2016-03-30 13:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 12:34 "perf hists browser: Support flat callchains" appears to have broken parent reporting Andres Freund
2016-03-30 13:46 ` Arnaldo Carvalho de Melo [this message]
2016-03-30 14:19 ` Andres Freund
2016-03-30 16:00 ` Namhyung Kim
2016-03-30 19:02 ` Andres Freund
2016-03-31 6:33 ` [tip:perf/urgent] perf hists: Fix determination of a callchain node's childlessness tip-bot for Andres Freund
2016-04-16 19:46 ` Andres Freund
2016-04-18 14:07 ` Arnaldo Carvalho de Melo
2016-04-18 14:25 ` Andres Freund
2016-05-02 22:17 ` Greg KH
2016-05-02 22:25 ` Andres Freund
2016-05-02 23:24 ` Greg KH
2016-05-02 23:34 ` Andres Freund
2016-03-30 21:07 ` "perf hists browser: Support flat callchains" appears to have broken parent reporting Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330134634.GA3420@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andres@anarazel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).