From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758946AbcDANYN (ORCPT ); Fri, 1 Apr 2016 09:24:13 -0400 Received: from mail.kernel.org ([198.145.29.136]:55218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753292AbcDANYK (ORCPT ); Fri, 1 Apr 2016 09:24:10 -0400 Date: Fri, 1 Apr 2016 10:24:06 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: He Kuang , peterz@infradead.org, Ingo Molnar , alexander.shishkin@linux.intel.com, Jiri Olsa , jpoimboe@redhat.com, sukadev@linux.vnet.ibm.com, eranian@google.com, wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: Fix build errors on tsc functions for archs other than x86 Message-ID: <20160401132406.GC7115@kernel.org> References: <1459482572-129494-1-git-send-email-hekuang@huawei.com> <20160401131312.GB7115@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160401131312.GB7115@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Apr 01, 2016 at 10:13:12AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Apr 01, 2016 at 03:49:32AM +0000, He Kuang escreveu: > > Build errors on aarch64: > > > > libperf.a(libperf-in.o): In function `convert_timestamp': > > util/jitdump.c:356: undefined reference to `tsc_to_perf_time' > > collect2: error: ld returned 1 exit status > > Makefile.perf:347: recipe for target 'perf' failed > > make[1]: *** [perf] Error 1 > > Makefile:68: recipe for target 'all' failed > > make: *** [all] Error 2 > > Got it, my cross-compile environment for aarch64 doesn't build jitdump.c > because it needs a package I haven't found in ubuntu: > > config/Makefile:416: No libcrypto.h found, disables jitted code injection, please install libssl-devel or libssl-dev > minimal-ubuntu-x-arm64: Ok > > BTW, He, what environment do you use to build for arm64, is it a cross > compile one? Yocto? Adrian, BTW, Ok with this? I'm adding a: Fixes: d3e58a3b8b3b ("perf jit: Add support for using TSC as a timestamp") And would appreciate your Acked-by. Thanks, - Arnaldo