From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756117AbcDDQCp (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Apr 2016 12:02:45 -0400
Received: from casper.infradead.org ([85.118.1.10]:40236 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752592AbcDDQCo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Apr 2016 12:02:44 -0400
Date: Mon, 4 Apr 2016 18:02:41 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>,
        Alfredo Alvarez Fernandez <alfredoalvarezfernandez@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Theodore Ts'o" <tytso@mit.edu>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-v4.6-rc1] ext4: WARNING: CPU: 2 PID: 2692 at
 kernel/locking/lockdep.c:2017 __lock_acquire+0x180e/0x2260
Message-ID: <20160404160241.GC3448@twins.programming.kicks-ass.net>
References: <CA+icZUVLbBD4xc7OjV112KHhxAnW_t3Fcpjht2SjVAo3Ds-Hrg@mail.gmail.com>
 <CA+icZUXgSK5VY7zJQ0bZZwKZmeYS+A7BRQD2fBBSzK=sM2aMLw@mail.gmail.com>
 <CA+55aFw-YXACVasN4n0h03QWgWWwvBray2fcMScAnEn0Wy_Ohw@mail.gmail.com>
 <20160327204810.GW6356@twins.programming.kicks-ass.net>
 <20160329084701.GA9393@gmail.com>
 <20160330093659.GS3408@twins.programming.kicks-ass.net>
 <20160330140636.GD11035@twins.programming.kicks-ass.net>
 <CA+icZUX3=q8=HGfvDm8JT6dbZ7QZutFBQsCk96zARHt26eHy8w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+icZUX3=q8=HGfvDm8JT6dbZ7QZutFBQsCk96zARHt26eHy8w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 04, 2016 at 05:31:40PM +0200, Sedat Dilek wrote:
> > +/* https://en.wikipedia.org/wiki/Xorshift#xorshift.2A */
> > +#define UINT64_C(x) x##ULL
> > +static inline u64 xorshift64star(u64 x)
> > +{
> > +       x ^= x >> 12; // a
> > +       x ^= x << 25; // b
> > +       x ^= x >> 27; // c
> > +       return x * UINT64_C(2685821657736338717);
> > +}

> Will you push that also to peterz/queue.git#locking/urgent?

Only after I've had a play and observed it making any difference; Dmitry
supposedly has a reproducer, but I've not yet had a moment to try.

> - Sedat -
> 
> P.S.: "lockdep: print chain_key collision information" in your above
> tree differs from the upstream one.

I'll drop mine, I just hadn't moved to the very latestestest tip.